git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Make "gitk" work with time-based arguments

From
Linus Torvalds <torvalds@osdl.org>
Date
Sep 20, 2005, 21:16 UTC
Message-ID
<Pine.LNX.4.58.0509201413300.2553@g5.osdl.org>

gitk wasn't able to take to take advantage of the new date parsing of git-rev-parse, because it didn't pass on arguments that needed quoting properly.

This is the black magic incantation necessary to make tcl do this right.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---
diff --git a/gitk b/gitk
--- a/gitk
+++ b/gitk
@@ -33,8 +33,8 @@ proc getcommits {rargs} {
     set nextupdate [expr $startmsecs + 100]
     set ncmupdate 1
     if [catch {
-	set parse_args [concat --default HEAD $rargs]
-	set parsed_args [split [eval exec git-rev-parse $parse_args] "\n"]
+	set parse_cmd [concat git-rev-parse --default HEAD $rargs]
+	set parsed_args [split [eval exec $parse_cmd] "\n"]
     }] {
 	# if git-rev-parse failed for some reason...
 	if {$rargs == {}} {
Message 1 of 1 in “Make "gitk" work with time-based arguments”
  1. Linus TorvaldsSep 20, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.