{"thread":{"id":"1893","subject":"Make \"gitk\" work with time-based arguments","startedAt":"2005-09-20T21:16:22Z","lastAt":"2005-09-20T21:16:22Z","messageCount":1,"participants":["Linus Torvalds"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"9016","messageId":"Pine.LNX.4.58.0509201413300.2553@g5.osdl.org","threadId":"1893","inReplyTo":null,"subject":"Make \"gitk\" work with time-based arguments","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-09-20T21:16:22Z","receivedAt":"2005-09-20T21:16:22Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\ngitk wasn't able to take to take advantage of the new date parsing of \ngit-rev-parse, because it didn't pass on arguments that needed quoting \nproperly.\n\nThis is the black magic incantation necessary to make tcl do this right.\n\nSigned-off-by: Linus Torvalds <torvalds@osdl.org>\n---\ndiff --git a/gitk b/gitk\n--- a/gitk\n+++ b/gitk\n@@ -33,8 +33,8 @@ proc getcommits {rargs} {\n     set nextupdate [expr $startmsecs + 100]\n     set ncmupdate 1\n     if [catch {\n-\tset parse_args [concat --default HEAD $rargs]\n-\tset parsed_args [split [eval exec git-rev-parse $parse_args] \"\\n\"]\n+\tset parse_cmd [concat git-rev-parse --default HEAD $rargs]\n+\tset parsed_args [split [eval exec $parse_cmd] \"\\n\"]\n     }] {\n \t# if git-rev-parse failed for some reason...\n \tif {$rargs == {}} {\n"}]}