threads / discuss / 18693

Broken t9001 tests

Subject: Broken t9001 tests

## tl;dr

4 messages between Apr 2, 2009 and Apr 2, 2009.

replies: 3people: 4as markdown or json

Johannes Schindelin· Apr 2, 2009, 13:22 UTC · lore

Hi,

only when I revert both dc1460a(send-email: ask_default should apply to all emails, not just the first) and c18f75a(send-email: add tests for refactored prompting) does my test suite pass without asking me _interactively_ (twice, even) if I want to

	Send this email? ([y]es|[n]o|[q]uit|[a]ll):

Please fix.

Ciao, Dscho

Jeff King· Apr 2, 2009, 13:40 UTC · re: Johannes Schindelin · lore

Re: Broken t9001 tests

On Thu, Apr 02, 2009 at 03:22:33PM +0200, Johannes Schindelin wrote:

Show 8 quoted lines

> only when I revert both dc1460a(send-email: ask_default should apply to 
> all emails, not just the first) and c18f75a(send-email: add tests for 
> refactored prompting) does my test suite pass without asking me 
> _interactively_ (twice, even) if I want to
> 
> 	Send this email? ([y]es|[n]o|[q]uit|[a]ll):
> 
> Please fix.

Try

  http://article.gmane.org/gmane.comp.version-control.git/115280

Junio seems to have picked up the first part of the series, but not this fix. I'm not sure why.

-Peff

Jay Soffian· Apr 2, 2009, 14:14 UTC · re: Jeff King · lore

Re: Broken t9001 tests

On Thu, Apr 2, 2009 at 9:40 AM, Jeff King <peff@peff.net> wrote:

Show 10 quoted lines

> On Thu, Apr 02, 2009 at 03:22:33PM +0200, Johannes Schindelin wrote:
>
>> only when I revert both dc1460a(send-email: ask_default should apply to
>> all emails, not just the first) and c18f75a(send-email: add tests for
>> refactored prompting) does my test suite pass without asking me
>> _interactively_ (twice, even) if I want to
>>
>>       Send this email? ([y]es|[n]o|[q]uit|[a]ll):
>>
>> Please fix.

Sorry, as Jeff mentions:

> Try
>
>  http://article.gmane.org/gmane.comp.version-control.git/115280

And BTW, it's not as if I didn't test. The "going interactive" issue is hidden by bash. But don't worry, I've since downloaded and installed dash just for running git tests, so it won't happen again.

> Junio seems to have picked up the first part of the series, but not this
> fix. I'm not sure why.

Junio, may I please draw you attention to 3/4 and 4/4 at the link above. Please amend the commit message for 3/4 though. It says it corrects commit 67f1fe5 which is wrong. Please sed 's/67f1fe5/c18f75a/' in that message.

Thanks,

j.

Junio C Hamano· Apr 2, 2009, 18:07 UTC · re: Jay Soffian · lore

Re: Broken t9001 tests

Jay Soffian <jaysoffian@gmail.com> writes:

Show 21 quoted lines

> On Thu, Apr 2, 2009 at 9:40 AM, Jeff King <peff@peff.net> wrote:
> ...
> Sorry, as Jeff mentions:
>
>> Try
>>
>>  http://article.gmane.org/gmane.comp.version-control.git/115280
>
> And BTW, it's not as if I didn't test. The "going interactive" issue
> is hidden by bash. But don't worry, I've since downloaded and
> installed dash just for running git tests, so it won't happen again.
>
>> Junio seems to have picked up the first part of the series, but not this
>> fix. I'm not sure why.
>
> Junio, may I please draw you attention to 3/4 and 4/4 at the link
> above. Please amend the commit message for 3/4 though. It says it
> corrects commit 67f1fe5 which is wrong. Please sed
> 's/67f1fe5/c18f75a/' in that message.
>
> Thanks,

Thanks, all of you.  I have been swamped.