Re: Broken t9001 tests

From: Jay Soffian <jaysoffian@gmail.com>
Date: Apr 2, 2009, 14:14 UTC
Message-ID: <76718490904020714x3f00d5fu6f13587be383be1b@mail.gmail.com>
In-Reply-To: <20090402134019.GA26699@coredump.intra.peff.net>

On Thu, Apr 2, 2009 at 9:40 AM, Jeff King <peff@peff.net> wrote:

Show 10 quoted lines

> On Thu, Apr 02, 2009 at 03:22:33PM +0200, Johannes Schindelin wrote:
>
>> only when I revert both dc1460a(send-email: ask_default should apply to
>> all emails, not just the first) and c18f75a(send-email: add tests for
>> refactored prompting) does my test suite pass without asking me
>> _interactively_ (twice, even) if I want to
>>
>>       Send this email? ([y]es|[n]o|[q]uit|[a]ll):
>>
>> Please fix.

Sorry, as Jeff mentions:

> Try
>
>  http://article.gmane.org/gmane.comp.version-control.git/115280

And BTW, it's not as if I didn't test. The "going interactive" issue is hidden by bash. But don't worry, I've since downloaded and installed dash just for running git tests, so it won't happen again.

> Junio seems to have picked up the first part of the series, but not this
> fix. I'm not sure why.

Junio, may I please draw you attention to 3/4 and 4/4 at the link above. Please amend the commit message for 3/4 though. It says it corrects commit 67f1fe5 which is wrong. Please sed 's/67f1fe5/c18f75a/' in that message.

Thanks,

j.