{"thread":{"id":"18693","subject":"Broken t9001 tests","startedAt":"2009-04-02T13:22:33Z","lastAt":"2009-04-02T18:07:18Z","messageCount":4,"participants":["Johannes Schindelin","Jeff King","Jay Soffian","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"110212","messageId":"alpine.DEB.1.00.0904021520200.7464@intel-tinevez-2-302","threadId":"18693","inReplyTo":null,"subject":"Broken t9001 tests","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-04-02T13:22:33Z","receivedAt":"2009-04-02T13:22:33Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nonly when I revert both dc1460a(send-email: ask_default should apply to \nall emails, not just the first) and c18f75a(send-email: add tests for \nrefactored prompting) does my test suite pass without asking me \n_interactively_ (twice, even) if I want to\n\n\tSend this email? ([y]es|[n]o|[q]uit|[a]ll):\n\nPlease fix.\n\nCiao,\nDscho\n"},{"id":"110215","messageId":"20090402134019.GA26699@coredump.intra.peff.net","threadId":"18693","inReplyTo":"alpine.DEB.1.00.0904021520200.7464@intel-tinevez-2-302","subject":"Re: Broken t9001 tests","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-04-02T13:40:19Z","receivedAt":"2009-04-02T13:40:19Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Apr 02, 2009 at 03:22:33PM +0200, Johannes Schindelin wrote:\n\n> only when I revert both dc1460a(send-email: ask_default should apply to \n> all emails, not just the first) and c18f75a(send-email: add tests for \n> refactored prompting) does my test suite pass without asking me \n> _interactively_ (twice, even) if I want to\n> \n> \tSend this email? ([y]es|[n]o|[q]uit|[a]ll):\n> \n> Please fix.\n\nTry\n\n  http://article.gmane.org/gmane.comp.version-control.git/115280\n\nJunio seems to have picked up the first part of the series, but not this\nfix. I'm not sure why.\n\n-Peff\n"},{"id":"110217","messageId":"76718490904020714x3f00d5fu6f13587be383be1b@mail.gmail.com","threadId":"18693","inReplyTo":"20090402134019.GA26699@coredump.intra.peff.net","subject":"Re: Broken t9001 tests","fromName":"Jay Soffian","fromEmail":"jaysoffian@gmail.com","sentAt":"2009-04-02T14:14:43Z","receivedAt":"2009-04-02T14:14:43Z","isPatch":false,"sender":{"key":"jaysoffian@gmail.com","avatar":"https://avatars.githubusercontent.com/u/155970?v=4"},"body":"On Thu, Apr 2, 2009 at 9:40 AM, Jeff King <peff@peff.net> wrote:\n> On Thu, Apr 02, 2009 at 03:22:33PM +0200, Johannes Schindelin wrote:\n>\n>> only when I revert both dc1460a(send-email: ask_default should apply to\n>> all emails, not just the first) and c18f75a(send-email: add tests for\n>> refactored prompting) does my test suite pass without asking me\n>> _interactively_ (twice, even) if I want to\n>>\n>>       Send this email? ([y]es|[n]o|[q]uit|[a]ll):\n>>\n>> Please fix.\n\nSorry, as Jeff mentions:\n\n> Try\n>\n>  http://article.gmane.org/gmane.comp.version-control.git/115280\n\nAnd BTW, it's not as if I didn't test. The \"going interactive\" issue\nis hidden by bash. But don't worry, I've since downloaded and\ninstalled dash just for running git tests, so it won't happen again.\n\n> Junio seems to have picked up the first part of the series, but not this\n> fix. I'm not sure why.\n\nJunio, may I please draw you attention to 3/4 and 4/4 at the link\nabove. Please amend the commit message for 3/4 though. It says it\ncorrects commit 67f1fe5 which is wrong. Please sed\n's/67f1fe5/c18f75a/' in that message.\n\nThanks,\n\nj.\n"},{"id":"110229","messageId":"7v3acrexpl.fsf@gitster.siamese.dyndns.org","threadId":"18693","inReplyTo":"76718490904020714x3f00d5fu6f13587be383be1b@mail.gmail.com","subject":"Re: Broken t9001 tests","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-04-02T18:07:18Z","receivedAt":"2009-04-02T18:07:18Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jay Soffian <jaysoffian@gmail.com> writes:\n\n> On Thu, Apr 2, 2009 at 9:40 AM, Jeff King <peff@peff.net> wrote:\n> ...\n> Sorry, as Jeff mentions:\n>\n>> Try\n>>\n>>  http://article.gmane.org/gmane.comp.version-control.git/115280\n>\n> And BTW, it's not as if I didn't test. The \"going interactive\" issue\n> is hidden by bash. But don't worry, I've since downloaded and\n> installed dash just for running git tests, so it won't happen again.\n>\n>> Junio seems to have picked up the first part of the series, but not this\n>> fix. I'm not sure why.\n>\n> Junio, may I please draw you attention to 3/4 and 4/4 at the link\n> above. Please amend the commit message for 3/4 though. It says it\n> corrects commit 67f1fe5 which is wrong. Please sed\n> 's/67f1fe5/c18f75a/' in that message.\n>\n> Thanks,\n\nThanks, all of you.  I have been swamped.\n"}]}