# Broken t9001 tests 4 messages from 2009-04-02 to 2009-04-02. Participants: Johannes Schindelin, Jeff King, Jay Soffian, Junio C Hamano. Thread: https://gitlist.dev/t/18693 ## Johannes Schindelin, 2009-04-02 13:22 Subject: Broken t9001 tests Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.0904021520200.7464%40intel-tinevez-2-302 ``` Hi, only when I revert both dc1460a(send-email: ask_default should apply to all emails, not just the first) and c18f75a(send-email: add tests for refactored prompting) does my test suite pass without asking me _interactively_ (twice, even) if I want to Send this email? ([y]es|[n]o|[q]uit|[a]ll): Please fix. Ciao, Dscho ``` ## Jeff King, 2009-04-02 13:40 Subject: Re: Broken t9001 tests Message-ID: <20090402134019.GA26699@coredump.intra.peff.net> URL: https://gitlist.dev/e/20090402134019.GA26699%40coredump.intra.peff.net In-Reply-To: ``` On Thu, Apr 02, 2009 at 03:22:33PM +0200, Johannes Schindelin wrote: > only when I revert both dc1460a(send-email: ask_default should apply to > all emails, not just the first) and c18f75a(send-email: add tests for > refactored prompting) does my test suite pass without asking me > _interactively_ (twice, even) if I want to > > Send this email? ([y]es|[n]o|[q]uit|[a]ll): > > Please fix. Try http://article.gmane.org/gmane.comp.version-control.git/115280 Junio seems to have picked up the first part of the series, but not this fix. I'm not sure why. -Peff ``` ## Jay Soffian, 2009-04-02 14:14 Subject: Re: Broken t9001 tests Message-ID: <76718490904020714x3f00d5fu6f13587be383be1b@mail.gmail.com> URL: https://gitlist.dev/e/76718490904020714x3f00d5fu6f13587be383be1b%40mail.gmail.com In-Reply-To: <20090402134019.GA26699@coredump.intra.peff.net> ``` On Thu, Apr 2, 2009 at 9:40 AM, Jeff King wrote: > On Thu, Apr 02, 2009 at 03:22:33PM +0200, Johannes Schindelin wrote: > >> only when I revert both dc1460a(send-email: ask_default should apply to >> all emails, not just the first) and c18f75a(send-email: add tests for >> refactored prompting) does my test suite pass without asking me >> _interactively_ (twice, even) if I want to >> >>       Send this email? ([y]es|[n]o|[q]uit|[a]ll): >> >> Please fix. Sorry, as Jeff mentions: > Try > >  http://article.gmane.org/gmane.comp.version-control.git/115280 And BTW, it's not as if I didn't test. The "going interactive" issue is hidden by bash. But don't worry, I've since downloaded and installed dash just for running git tests, so it won't happen again. > Junio seems to have picked up the first part of the series, but not this > fix. I'm not sure why. Junio, may I please draw you attention to 3/4 and 4/4 at the link above. Please amend the commit message for 3/4 though. It says it corrects commit 67f1fe5 which is wrong. Please sed 's/67f1fe5/c18f75a/' in that message. Thanks, j. ``` ## Junio C Hamano, 2009-04-02 18:07 Subject: Re: Broken t9001 tests Message-ID: <7v3acrexpl.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7v3acrexpl.fsf%40gitster.siamese.dyndns.org In-Reply-To: <76718490904020714x3f00d5fu6f13587be383be1b@mail.gmail.com> ``` Jay Soffian writes: > On Thu, Apr 2, 2009 at 9:40 AM, Jeff King wrote: > ... > Sorry, as Jeff mentions: > >> Try >> >>  http://article.gmane.org/gmane.comp.version-control.git/115280 > > And BTW, it's not as if I didn't test. The "going interactive" issue > is hidden by bash. But don't worry, I've since downloaded and > installed dash just for running git tests, so it won't happen again. > >> Junio seems to have picked up the first part of the series, but not this >> fix. I'm not sure why. > > Junio, may I please draw you attention to 3/4 and 4/4 at the link > above. Please amend the commit message for 3/4 though. It says it > corrects commit 67f1fe5 which is wrong. Please sed > 's/67f1fe5/c18f75a/' in that message. > > Thanks, Thanks, all of you. I have been swamped. ```