threads / patch / 17214

patchRe: [PATCH resend] bash completion: add 'rename' subcommand to git-remote

Subject: Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote

## tl;dr

5 messages between Jan 16, 2009 and Jan 21, 2009. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Shawn O. Pearce· Jan 16, 2009, 22:12 UTC · lore
Markus Heidelberg <markus.heidelberg@web.de> wrote:
> 
> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
> 	I've just accidently read in the completion file itself, that
> 	Shawn is the maintainer, so I give it a third try. The first two
> 	haven't been sent to him.
Sorry, I must have missed the other two attempts.  :-)
 
Show 28 quoted lines
>  contrib/completion/git-completion.bash |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 049ded0..6623344 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1384,7 +1384,7 @@ _git_config ()
>  
>  _git_remote ()
>  {
> -	local subcommands="add rm show prune update"
> +	local subcommands="add rename rm show prune update"
>  	local subcommand="$(__git_find_subcommand "$subcommands")"
>  	if [ -z "$subcommand" ]; then
>  		__gitcomp "$subcommands"
> @@ -1392,7 +1392,7 @@ _git_remote ()
>  	fi
>  
>  	case "$subcommand" in
> -	rm|show|prune)
> +	rename|rm|show|prune)
>  		__gitcomp "$(__git_remotes)"
>  		;;
>  	update)
> -- 
> 1.6.1.35.g0c23
> 
-- 
Shawn.
Junio C Hamano· Jan 17, 2009, 08:03 UTC · re: Shawn O. Pearce · lore
"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 11 quoted lines
> Markus Heidelberg <markus.heidelberg@web.de> wrote:
>> 
>> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>
>
>> 	I've just accidently read in the completion file itself, that
>> 	Shawn is the maintainer, so I give it a third try. The first two
>> 	haven't been sent to him.
>
> Sorry, I must have missed the other two attempts.  :-)
And I seem to have missed all three.
Show 37 quoted lines
>
>  
>>  contrib/completion/git-completion.bash |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>> index 049ded0..6623344 100755
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -1384,7 +1384,7 @@ _git_config ()
>>  
>>  _git_remote ()
>>  {
>> -	local subcommands="add rm show prune update"
>> +	local subcommands="add rename rm show prune update"
>>  	local subcommand="$(__git_find_subcommand "$subcommands")"
>>  	if [ -z "$subcommand" ]; then
>>  		__gitcomp "$subcommands"
>> @@ -1392,7 +1392,7 @@ _git_remote ()
>>  	fi
>>  
>>  	case "$subcommand" in
>> -	rm|show|prune)
>> +	rename|rm|show|prune)
>>  		__gitcomp "$(__git_remotes)"
>>  		;;
>>  	update)
>> -- 
>> 1.6.1.35.g0c23
>> 
>
> -- 
> Shawn.
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Markus Heidelberg· Jan 20, 2009, 18:21 UTC · re: Junio C Hamano · lore
Junio C Hamano, 17.01.2009:
Show 15 quoted lines
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > Markus Heidelberg <markus.heidelberg@web.de> wrote:
> >> 
> >> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> >
> > Acked-by: Shawn O. Pearce <spearce@spearce.org>
> >
> >> 	I've just accidently read in the completion file itself, that
> >> 	Shawn is the maintainer, so I give it a third try. The first two
> >> 	haven't been sent to him.
> >
> > Sorry, I must have missed the other two attempts.  :-)
> 
> And I seem to have missed all three.

I really don't like to bother you again, but compared to the inclusion of the other patches, I guess you have forgotten the third try of this patch.

Thus this fourth try :)
Markus
Show 27 quoted lines
> >>  contrib/completion/git-completion.bash |    4 ++--
> >>  1 files changed, 2 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> >> index 049ded0..6623344 100755
> >> --- a/contrib/completion/git-completion.bash
> >> +++ b/contrib/completion/git-completion.bash
> >> @@ -1384,7 +1384,7 @@ _git_config ()
> >>  
> >>  _git_remote ()
> >>  {
> >> -	local subcommands="add rm show prune update"
> >> +	local subcommands="add rename rm show prune update"
> >>  	local subcommand="$(__git_find_subcommand "$subcommands")"
> >>  	if [ -z "$subcommand" ]; then
> >>  		__gitcomp "$subcommands"
> >> @@ -1392,7 +1392,7 @@ _git_remote ()
> >>  	fi
> >>  
> >>  	case "$subcommand" in
> >> -	rm|show|prune)
> >> +	rename|rm|show|prune)
> >>  		__gitcomp "$(__git_remotes)"
> >>  		;;
> >>  	update)
> >> -- 
> >> 1.6.1.35.g0c23
Junio C Hamano· Jan 21, 2009, 10:26 UTC · re: Markus Heidelberg · lore
Markus Heidelberg <markus.heidelberg@web.de> writes:
Show 22 quoted lines
> Junio C Hamano, 17.01.2009:
>> "Shawn O. Pearce" <spearce@spearce.org> writes:
>> 
>> > Markus Heidelberg <markus.heidelberg@web.de> wrote:
>> >> 
>> >> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
>> >
>> > Acked-by: Shawn O. Pearce <spearce@spearce.org>
>> >
>> >> 	I've just accidently read in the completion file itself, that
>> >> 	Shawn is the maintainer, so I give it a third try. The first two
>> >> 	haven't been sent to him.
>> >
>> > Sorry, I must have missed the other two attempts.  :-)
>> 
>> And I seem to have missed all three.
>
> I really don't like to bother you again, but compared to the inclusion
> of the other patches, I guess you have forgotten the third try of this
> patch.
>
> Thus this fourth try :)

I did not mean that I forgot by the above "I seem to have missed". Literally none of your three attempts seem to have reached me. I can guess what you wrote from the _included_ text in Shawn's response, but that is not a good/right place for me to pick up a patch from, is it?

Markus Heidelberg· Jan 21, 2009, 22:59 UTC · re: Junio C Hamano · lore
Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
---
Show 8 quoted lines
> > I really don't like to bother you again, but compared to the inclusion
> > of the other patches, I guess you have forgotten the third try of this
> > patch.
> >
> > Thus this fourth try :)
> 
> I did not mean that I forgot by the above "I seem to have missed".
> Literally none of your three attempts seem to have reached me.
Ah, OK. With "missed" I thought you have just overlooked them.
> I can
> guess what you wrote from the _included_ text in Shawn's response, but
> that is not a good/right place for me to pick up a patch from, is it?
No, it isn't.

next mail: I just don't get it. The previous mail, I sent three a half hours ago, didn't reach the list either. Am I doing anything wrong? I looked at the archives: the first two got to the list, the 3rd (with the Acked-by from Shawn) and 4th didn't. Now this is the 5th. I can't remember any such problems with mail delivery.

 contrib/completion/git-completion.bash |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Show changes to contrib/completion/git-completion.bash +2 −2
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 3ce6de2..f2d6cad 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1391,7 +1391,7 @@ _git_config ()
 
 _git_remote ()
 {
-	local subcommands="add rm show prune update"
+	local subcommands="add rename rm show prune update"
 	local subcommand="$(__git_find_subcommand "$subcommands")"
 	if [ -z "$subcommand" ]; then
 		__gitcomp "$subcommands"
@@ -1399,7 +1399,7 @@ _git_remote ()
 	fi
 
 	case "$subcommand" in
-	rm|show|prune)
+	rename|rm|show|prune)
 		__gitcomp "$(__git_remotes)"
 		;;
 	update)
-- 
1.6.1.227.gad9c0

← back to recent threads