{"thread":{"id":"17214","subject":"Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote","startedAt":"2009-01-16T22:12:03Z","lastAt":"2009-01-21T22:59:22Z","messageCount":5,"participants":["Shawn O. Pearce","Junio C Hamano","Markus Heidelberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"100779","messageId":"20090116221203.GP10179@spearce.org","threadId":"17214","inReplyTo":"200901162254.58300.markus.heidelberg@web.de","subject":"Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-01-16T22:12:03Z","receivedAt":"2009-01-16T22:12:03Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Markus Heidelberg wrote:\n> \n> Signed-off-by: Markus Heidelberg \n\nAcked-by: Shawn O. Pearce \n\n> \tI've just accidently read in the completion file itself, that\n> \tShawn is the maintainer, so I give it a third try. The first two\n> \thaven't been sent to him.\n\nSorry, I must have missed the other two attempts. :-)\n\n \n> contrib/completion/git-completion.bash | 4 ++--\n> 1 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 049ded0..6623344 100755\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1384,7 +1384,7 @@ _git_config ()\n> \n> _git_remote ()\n> {\n> -\tlocal subcommands=\"add rm show prune update\"\n> +\tlocal subcommands=\"add rename rm show prune update\"\n> \tlocal subcommand=\"$(__git_find_subcommand \"$subcommands\")\"\n> \tif [ -z \"$subcommand\" ]; then\n> \t\t__gitcomp \"$subcommands\"\n> @@ -1392,7 +1392,7 @@ _git_remote ()\n> \tfi\n> \n> \tcase \"$subcommand\" in\n> -\trm|show|prune)\n> +\trename|rm|show|prune)\n> \t\t__gitcomp \"$(__git_remotes)\"\n> \t\t;;\n> \tupdate)\n> -- \n> 1.6.1.35.g0c23\n> \n\n-- \nShawn.\n"},{"id":"100811","messageId":"7vd4em8ilx.fsf@gitster.siamese.dyndns.org","threadId":"17214","inReplyTo":"20090116221203.GP10179@spearce.org","subject":"Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-17T08:03:22Z","receivedAt":"2009-01-17T08:03:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Shawn O. Pearce\" writes:\n\n> Markus Heidelberg wrote:\n>> \n>> Signed-off-by: Markus Heidelberg \n>\n> Acked-by: Shawn O. Pearce \n>\n>> \tI've just accidently read in the completion file itself, that\n>> \tShawn is the maintainer, so I give it a third try. The first two\n>> \thaven't been sent to him.\n>\n> Sorry, I must have missed the other two attempts. :-)\n\nAnd I seem to have missed all three.\n\n>\n> \n>> contrib/completion/git-completion.bash | 4 ++--\n>> 1 files changed, 2 insertions(+), 2 deletions(-)\n>> \n>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n>> index 049ded0..6623344 100755\n>> --- a/contrib/completion/git-completion.bash\n>> +++ b/contrib/completion/git-completion.bash\n>> @@ -1384,7 +1384,7 @@ _git_config ()\n>> \n>> _git_remote ()\n>> {\n>> -\tlocal subcommands=\"add rm show prune update\"\n>> +\tlocal subcommands=\"add rename rm show prune update\"\n>> \tlocal subcommand=\"$(__git_find_subcommand \"$subcommands\")\"\n>> \tif [ -z \"$subcommand\" ]; then\n>> \t\t__gitcomp \"$subcommands\"\n>> @@ -1392,7 +1392,7 @@ _git_remote ()\n>> \tfi\n>> \n>> \tcase \"$subcommand\" in\n>> -\trm|show|prune)\n>> +\trename|rm|show|prune)\n>> \t\t__gitcomp \"$(__git_remotes)\"\n>> \t\t;;\n>> \tupdate)\n>> -- \n>> 1.6.1.35.g0c23\n>> \n>\n> -- \n> Shawn.\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n"},{"id":"101284","messageId":"200901201921.10223.markus.heidelberg@web.de","threadId":"17214","inReplyTo":"7vd4em8ilx.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-01-20T18:21:09Z","receivedAt":"2009-01-20T18:21:09Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"Junio C Hamano, 17.01.2009:\n> \"Shawn O. Pearce\" writes:\n> \n> > Markus Heidelberg wrote:\n> >> \n> >> Signed-off-by: Markus Heidelberg \n> >\n> > Acked-by: Shawn O. Pearce \n> >\n> >> \tI've just accidently read in the completion file itself, that\n> >> \tShawn is the maintainer, so I give it a third try. The first two\n> >> \thaven't been sent to him.\n> >\n> > Sorry, I must have missed the other two attempts. :-)\n> \n> And I seem to have missed all three.\n\nI really don't like to bother you again, but compared to the inclusion\nof the other patches, I guess you have forgotten the third try of this\npatch.\n\nThus this fourth try :)\n\nMarkus\n\n\n> >> contrib/completion/git-completion.bash | 4 ++--\n> >> 1 files changed, 2 insertions(+), 2 deletions(-)\n> >> \n> >> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> >> index 049ded0..6623344 100755\n> >> --- a/contrib/completion/git-completion.bash\n> >> +++ b/contrib/completion/git-completion.bash\n> >> @@ -1384,7 +1384,7 @@ _git_config ()\n> >> \n> >> _git_remote ()\n> >> {\n> >> -\tlocal subcommands=\"add rm show prune update\"\n> >> +\tlocal subcommands=\"add rename rm show prune update\"\n> >> \tlocal subcommand=\"$(__git_find_subcommand \"$subcommands\")\"\n> >> \tif [ -z \"$subcommand\" ]; then\n> >> \t\t__gitcomp \"$subcommands\"\n> >> @@ -1392,7 +1392,7 @@ _git_remote ()\n> >> \tfi\n> >> \n> >> \tcase \"$subcommand\" in\n> >> -\trm|show|prune)\n> >> +\trename|rm|show|prune)\n> >> \t\t__gitcomp \"$(__git_remotes)\"\n> >> \t\t;;\n> >> \tupdate)\n> >> -- \n> >> 1.6.1.35.g0c23\n"},{"id":"101366","messageId":"7veiyxeyzr.fsf@gitster.siamese.dyndns.org","threadId":"17214","inReplyTo":"200901201921.10223.markus.heidelberg@web.de","subject":"Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-21T10:26:32Z","receivedAt":"2009-01-21T10:26:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Markus Heidelberg writes:\n\n> Junio C Hamano, 17.01.2009:\n>> \"Shawn O. Pearce\" writes:\n>> \n>> > Markus Heidelberg wrote:\n>> >> \n>> >> Signed-off-by: Markus Heidelberg \n>> >\n>> > Acked-by: Shawn O. Pearce \n>> >\n>> >> \tI've just accidently read in the completion file itself, that\n>> >> \tShawn is the maintainer, so I give it a third try. The first two\n>> >> \thaven't been sent to him.\n>> >\n>> > Sorry, I must have missed the other two attempts. :-)\n>> \n>> And I seem to have missed all three.\n>\n> I really don't like to bother you again, but compared to the inclusion\n> of the other patches, I guess you have forgotten the third try of this\n> patch.\n>\n> Thus this fourth try :)\n\nI did not mean that I forgot by the above \"I seem to have missed\".\nLiterally none of your three attempts seem to have reached me. I can\nguess what you wrote from the _included_ text in Shawn's response, but\nthat is not a good/right place for me to pick up a patch from, is it?\n"},{"id":"101475","messageId":"200901212359.23241.markus.heidelberg@web.de","threadId":"17214","inReplyTo":"7veiyxeyzr.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-01-21T22:59:22Z","receivedAt":"2009-01-21T22:59:22Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"\nSigned-off-by: Markus Heidelberg \nAcked-by: Shawn O. Pearce \n---\n\n> > I really don't like to bother you again, but compared to the inclusion\n> > of the other patches, I guess you have forgotten the third try of this\n> > patch.\n> >\n> > Thus this fourth try :)\n> \n> I did not mean that I forgot by the above \"I seem to have missed\".\n> Literally none of your three attempts seem to have reached me.\n\nAh, OK. With \"missed\" I thought you have just overlooked them.\n\n> I can\n> guess what you wrote from the _included_ text in Shawn's response, but\n> that is not a good/right place for me to pick up a patch from, is it?\n\nNo, it isn't.\n\n\nnext mail:\nI just don't get it. The previous mail, I sent three a half hours ago,\ndidn't reach the list either. Am I doing anything wrong? I looked at\nthe archives: the first two got to the list, the 3rd (with the Acked-by\nfrom Shawn) and 4th didn't. Now this is the 5th. I can't remember any\nsuch problems with mail delivery.\n\n\n contrib/completion/git-completion.bash | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 3ce6de2..f2d6cad 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1391,7 +1391,7 @@ _git_config ()\n \n _git_remote ()\n {\n-\tlocal subcommands=\"add rm show prune update\"\n+\tlocal subcommands=\"add rename rm show prune update\"\n \tlocal subcommand=\"$(__git_find_subcommand \"$subcommands\")\"\n \tif [ -z \"$subcommand\" ]; then\n \t\t__gitcomp \"$subcommands\"\n@@ -1399,7 +1399,7 @@ _git_remote ()\n \tfi\n \n \tcase \"$subcommand\" in\n-\trm|show|prune)\n+\trename|rm|show|prune)\n \t\t__gitcomp \"$(__git_remotes)\"\n \t\t;;\n \tupdate)\n-- \n1.6.1.227.gad9c0\n"}]}