Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Jan 20, 2009, 18:21 UTC
Message-ID: <200901201921.10223.markus.heidelberg@web.de>
In-Reply-To: <7vd4em8ilx.fsf@gitster.siamese.dyndns.org>

Junio C Hamano, 17.01.2009:

Show 15 quoted lines

> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > Markus Heidelberg <markus.heidelberg@web.de> wrote:
> >> 
> >> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> >
> > Acked-by: Shawn O. Pearce <spearce@spearce.org>
> >
> >> 	I've just accidently read in the completion file itself, that
> >> 	Shawn is the maintainer, so I give it a third try. The first two
> >> 	haven't been sent to him.
> >
> > Sorry, I must have missed the other two attempts.  :-)
> 
> And I seem to have missed all three.

I really don't like to bother you again, but compared to the inclusion of the other patches, I guess you have forgotten the third try of this patch.

Thus this fourth try :)

Markus

Show 27 quoted lines

> >>  contrib/completion/git-completion.bash |    4 ++--
> >>  1 files changed, 2 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> >> index 049ded0..6623344 100755
> >> --- a/contrib/completion/git-completion.bash
> >> +++ b/contrib/completion/git-completion.bash
> >> @@ -1384,7 +1384,7 @@ _git_config ()
> >>  
> >>  _git_remote ()
> >>  {
> >> -	local subcommands="add rm show prune update"
> >> +	local subcommands="add rename rm show prune update"
> >>  	local subcommand="$(__git_find_subcommand "$subcommands")"
> >>  	if [ -z "$subcommand" ]; then
> >>  		__gitcomp "$subcommands"
> >> @@ -1392,7 +1392,7 @@ _git_remote ()
> >>  	fi
> >>  
> >>  	case "$subcommand" in
> >> -	rm|show|prune)
> >> +	rename|rm|show|prune)
> >>  		__gitcomp "$(__git_remotes)"
> >>  		;;
> >>  	update)
> >> -- 
> >> 1.6.1.35.g0c23