# Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote 5 messages from 2009-01-16 to 2009-01-21. Participants: Shawn O. Pearce, Junio C Hamano, Markus Heidelberg. Thread: https://gitlist.dev/t/17214 ## Shawn O. Pearce, 2009-01-16 22:12 Subject: Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote Message-ID: <20090116221203.GP10179@spearce.org> URL: https://gitlist.dev/e/20090116221203.GP10179%40spearce.org In-Reply-To: <200901162254.58300.markus.heidelberg@web.de> ``` Markus Heidelberg wrote: > > Signed-off-by: Markus Heidelberg Acked-by: Shawn O. Pearce > I've just accidently read in the completion file itself, that > Shawn is the maintainer, so I give it a third try. The first two > haven't been sent to him. Sorry, I must have missed the other two attempts. :-) > contrib/completion/git-completion.bash | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index 049ded0..6623344 100755 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -1384,7 +1384,7 @@ _git_config () > > _git_remote () > { > - local subcommands="add rm show prune update" > + local subcommands="add rename rm show prune update" > local subcommand="$(__git_find_subcommand "$subcommands")" > if [ -z "$subcommand" ]; then > __gitcomp "$subcommands" > @@ -1392,7 +1392,7 @@ _git_remote () > fi > > case "$subcommand" in > - rm|show|prune) > + rename|rm|show|prune) > __gitcomp "$(__git_remotes)" > ;; > update) > -- > 1.6.1.35.g0c23 > -- Shawn. ``` ## Junio C Hamano, 2009-01-17 08:03 Subject: Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote Message-ID: <7vd4em8ilx.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vd4em8ilx.fsf%40gitster.siamese.dyndns.org In-Reply-To: <20090116221203.GP10179@spearce.org> ``` "Shawn O. Pearce" writes: > Markus Heidelberg wrote: >> >> Signed-off-by: Markus Heidelberg > > Acked-by: Shawn O. Pearce > >> I've just accidently read in the completion file itself, that >> Shawn is the maintainer, so I give it a third try. The first two >> haven't been sent to him. > > Sorry, I must have missed the other two attempts. :-) And I seem to have missed all three. > > >> contrib/completion/git-completion.bash | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash >> index 049ded0..6623344 100755 >> --- a/contrib/completion/git-completion.bash >> +++ b/contrib/completion/git-completion.bash >> @@ -1384,7 +1384,7 @@ _git_config () >> >> _git_remote () >> { >> - local subcommands="add rm show prune update" >> + local subcommands="add rename rm show prune update" >> local subcommand="$(__git_find_subcommand "$subcommands")" >> if [ -z "$subcommand" ]; then >> __gitcomp "$subcommands" >> @@ -1392,7 +1392,7 @@ _git_remote () >> fi >> >> case "$subcommand" in >> - rm|show|prune) >> + rename|rm|show|prune) >> __gitcomp "$(__git_remotes)" >> ;; >> update) >> -- >> 1.6.1.35.g0c23 >> > > -- > Shawn. > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ``` ## Markus Heidelberg, 2009-01-20 18:21 Subject: Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote Message-ID: <200901201921.10223.markus.heidelberg@web.de> URL: https://gitlist.dev/e/200901201921.10223.markus.heidelberg%40web.de In-Reply-To: <7vd4em8ilx.fsf@gitster.siamese.dyndns.org> ``` Junio C Hamano, 17.01.2009: > "Shawn O. Pearce" writes: > > > Markus Heidelberg wrote: > >> > >> Signed-off-by: Markus Heidelberg > > > > Acked-by: Shawn O. Pearce > > > >> I've just accidently read in the completion file itself, that > >> Shawn is the maintainer, so I give it a third try. The first two > >> haven't been sent to him. > > > > Sorry, I must have missed the other two attempts. :-) > > And I seem to have missed all three. I really don't like to bother you again, but compared to the inclusion of the other patches, I guess you have forgotten the third try of this patch. Thus this fourth try :) Markus > >> contrib/completion/git-completion.bash | 4 ++-- > >> 1 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > >> index 049ded0..6623344 100755 > >> --- a/contrib/completion/git-completion.bash > >> +++ b/contrib/completion/git-completion.bash > >> @@ -1384,7 +1384,7 @@ _git_config () > >> > >> _git_remote () > >> { > >> - local subcommands="add rm show prune update" > >> + local subcommands="add rename rm show prune update" > >> local subcommand="$(__git_find_subcommand "$subcommands")" > >> if [ -z "$subcommand" ]; then > >> __gitcomp "$subcommands" > >> @@ -1392,7 +1392,7 @@ _git_remote () > >> fi > >> > >> case "$subcommand" in > >> - rm|show|prune) > >> + rename|rm|show|prune) > >> __gitcomp "$(__git_remotes)" > >> ;; > >> update) > >> -- > >> 1.6.1.35.g0c23 ``` ## Junio C Hamano, 2009-01-21 10:26 Subject: Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote Message-ID: <7veiyxeyzr.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7veiyxeyzr.fsf%40gitster.siamese.dyndns.org In-Reply-To: <200901201921.10223.markus.heidelberg@web.de> ``` Markus Heidelberg writes: > Junio C Hamano, 17.01.2009: >> "Shawn O. Pearce" writes: >> >> > Markus Heidelberg wrote: >> >> >> >> Signed-off-by: Markus Heidelberg >> > >> > Acked-by: Shawn O. Pearce >> > >> >> I've just accidently read in the completion file itself, that >> >> Shawn is the maintainer, so I give it a third try. The first two >> >> haven't been sent to him. >> > >> > Sorry, I must have missed the other two attempts. :-) >> >> And I seem to have missed all three. > > I really don't like to bother you again, but compared to the inclusion > of the other patches, I guess you have forgotten the third try of this > patch. > > Thus this fourth try :) I did not mean that I forgot by the above "I seem to have missed". Literally none of your three attempts seem to have reached me. I can guess what you wrote from the _included_ text in Shawn's response, but that is not a good/right place for me to pick up a patch from, is it? ``` ## Markus Heidelberg, 2009-01-21 22:59 Subject: Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote Message-ID: <200901212359.23241.markus.heidelberg@web.de> URL: https://gitlist.dev/e/200901212359.23241.markus.heidelberg%40web.de In-Reply-To: <7veiyxeyzr.fsf@gitster.siamese.dyndns.org> ``` Signed-off-by: Markus Heidelberg Acked-by: Shawn O. Pearce --- > > I really don't like to bother you again, but compared to the inclusion > > of the other patches, I guess you have forgotten the third try of this > > patch. > > > > Thus this fourth try :) > > I did not mean that I forgot by the above "I seem to have missed". > Literally none of your three attempts seem to have reached me. Ah, OK. With "missed" I thought you have just overlooked them. > I can > guess what you wrote from the _included_ text in Shawn's response, but > that is not a good/right place for me to pick up a patch from, is it? No, it isn't. next mail: I just don't get it. The previous mail, I sent three a half hours ago, didn't reach the list either. Am I doing anything wrong? I looked at the archives: the first two got to the list, the 3rd (with the Acked-by from Shawn) and 4th didn't. Now this is the 5th. I can't remember any such problems with mail delivery. contrib/completion/git-completion.bash | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 3ce6de2..f2d6cad 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1391,7 +1391,7 @@ _git_config () _git_remote () { - local subcommands="add rm show prune update" + local subcommands="add rename rm show prune update" local subcommand="$(__git_find_subcommand "$subcommands")" if [ -z "$subcommand" ]; then __gitcomp "$subcommands" @@ -1399,7 +1399,7 @@ _git_remote () fi case "$subcommand" in - rm|show|prune) + rename|rm|show|prune) __gitcomp "$(__git_remotes)" ;; update) -- 1.6.1.227.gad9c0 ```