threads / patch / 16760

patchDocumentation: fix description for enabling hooks

Subject: [PATCH] Documentation: fix description for enabling hooks

## tl;dr

6 messages between Dec 17, 2008 and Dec 17, 2008. Diffs are folded; open one to read it.

replies: 5people: 3as markdown or json

Markus Heidelberg· Dec 17, 2008, 02:59 UTC · lore

Since f98f8cb (Ship sample hooks with .sample suffix, 2008-06-24) hooks are not enabled by making them executable anymore, but by removing the '.sample' suffix from the filename.

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
 Documentation/gitrepository-layout.txt |    3 ++-
 Documentation/glossary-content.txt     |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
Show changes to 2 files +4 −2

Documentation/gitrepository-layout.txt, Documentation/glossary-content.txt

diff --git a/Documentation/gitrepository-layout.txt b/Documentation/gitrepository-layout.txt
index a969b3f..1befca9 100644
--- a/Documentation/gitrepository-layout.txt
+++ b/Documentation/gitrepository-layout.txt
@@ -134,7 +134,8 @@ hooks::
 	Hooks are customization scripts used by various git
 	commands.  A handful of sample hooks are installed when
 	'git-init' is run, but all of them are disabled by
-	default.  To enable, they need to be made executable.
+	default.  To enable, the `.sample` suffix has to be
+	removed from the filename by renaming.
 	Read linkgit:githooks[5] for more details about
 	each hook.
 
diff --git a/Documentation/glossary-content.txt b/Documentation/glossary-content.txt
index 9b4a4f4..9afca75 100644
--- a/Documentation/glossary-content.txt
+++ b/Documentation/glossary-content.txt
@@ -183,7 +183,8 @@ to point at the new commit.
 	and potentially aborted, and allow for a post-notification after the
 	operation is done. The hook scripts are found in the
 	`$GIT_DIR/hooks/` directory, and are enabled by simply
-	making them executable.
+	removing the `.sample` suffix from the filename. In earlier versions
+	of git you had to make them executable.
 
 [[def_index]]index::
 	A collection of files with stat information, whose contents are stored

-- 
1.6.1.rc3.23.gaf48b
Miklos Vajna· Dec 17, 2008, 04:13 UTC · re: Markus Heidelberg · lore

Re: [PATCH] Documentation: fix description for enabling hooks

On Wed, Dec 17, 2008 at 03:59:23AM +0100, Markus Heidelberg <markus.heidelberg@web.de> wrote:
> Since f98f8cb (Ship sample hooks with .sample suffix, 2008-06-24) hooks
> are not enabled by making them executable anymore, but by removing the
> '.sample' suffix from the filename.

This is true, but having the executable bit is necessary as well. I think it would be better to just append this requirement instead of replacing the old one with this.

Johannes Sixt· Dec 17, 2008, 07:44 UTC · re: Miklos Vajna · lore

Re: [PATCH] Documentation: fix description for enabling hooks

Miklos Vajna schrieb:
Show 8 quoted lines
> On Wed, Dec 17, 2008 at 03:59:23AM +0100, Markus Heidelberg <markus.heidelberg@web.de> wrote:
>> Since f98f8cb (Ship sample hooks with .sample suffix, 2008-06-24) hooks
>> are not enabled by making them executable anymore, but by removing the
>> '.sample' suffix from the filename.
> 
> This is true, but having the executable bit is necessary as well. I
> think it would be better to just append this requirement instead of
> replacing the old one with this.

Markus's proposed new wording is correct because the .sample hooks *are* already executable.

-- Hannes
Miklos Vajna· Dec 17, 2008, 14:36 UTC · re: Johannes Sixt · lore

Re: [PATCH] Documentation: fix description for enabling hooks

On Wed, Dec 17, 2008 at 08:44:40AM +0100, Johannes Sixt <j.sixt@viscovery.net> wrote:
Show 6 quoted lines
> > This is true, but having the executable bit is necessary as well. I
> > think it would be better to just append this requirement instead of
> > replacing the old one with this.
> 
> Markus's proposed new wording is correct because the .sample hooks *are*
> already executable.

I thought about the following situation: The user reads the documentation while working in an older repo (initialized a few versions ago). S/he sees that the .sample suffix is already missing, so s/he assumes that the hook is already active. Which is not true, because the +x bit is missing.

Markus Heidelberg· Dec 17, 2008, 19:55 UTC · re: Miklos Vajna · lore

Re: [PATCH] Documentation: fix description for enabling hooks

Miklos Vajna, 17.12.2008:
Show 13 quoted lines
> On Wed, Dec 17, 2008 at 08:44:40AM +0100, Johannes Sixt <j.sixt@viscovery.net> wrote:
> > > This is true, but having the executable bit is necessary as well. I
> > > think it would be better to just append this requirement instead of
> > > replacing the old one with this.
> > 
> > Markus's proposed new wording is correct because the .sample hooks *are*
> > already executable.
> 
> I thought about the following situation: The user reads the
> documentation while working in an older repo (initialized a few versions
> ago). S/he sees that the .sample suffix is already missing, so s/he
> assumes that the hook is already active. Which is not true, because the
> +x bit is missing.

Valid point, I think, but not critical in this case, since the patch only affected gitrepository-layout(5) and gitglossary(7).

When you want to learn how to use hooks, you will probably rather read githooks(5), where the need for the executable bit is not even explicitly mentioned. Maybe it should be added there?

Markus
Miklos Vajna· Dec 17, 2008, 21:29 UTC · re: Markus Heidelberg · lore

[PATCH] githooks documentation: add a note about the +x mode

In a freshly initialized repo it is only necessary to rename the .sample hooks, but when using older repos (initialized with older git init) enabled the +x mode is still necessary - docuement this.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
On Wed, Dec 17, 2008 at 08:55:45PM +0100, Markus Heidelberg <markus.heidelberg@web.de> wrote:
> When you want to learn how to use hooks, you will probably rather read
> githooks(5), where the need for the executable bit is not even
> explicitly mentioned. Maybe it should be added there?
I think so.
 Documentation/githooks.txt |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Show changes to Documentation/githooks.txt +4 −0
diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
index 5faaaa5..cfdae1e 100644
--- a/Documentation/githooks.txt
+++ b/Documentation/githooks.txt
@@ -20,6 +20,10 @@ directory to trigger action at certain points.  When
 all disabled.  To enable a hook, rename it by removing its `.sample`
 suffix.
 
+NOTE: It is also a requirement for a given hook to be executable.
+However - in a freshly initialized repository - the `.sample` files are
+executable by default.
+
 This document describes the currently defined hooks.
 
 applypatch-msg

-- 
1.6.1.rc1.35.gae26e.dirty

← back to recent threads