Re: [PATCH] Documentation: fix description for enabling hooks

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Dec 17, 2008, 19:55 UTC
Message-ID: <200812172055.45905.markus.heidelberg@web.de>
In-Reply-To: <20081217143627.GB5691@genesis.frugalware.org>

Miklos Vajna, 17.12.2008:

Show 13 quoted lines

> On Wed, Dec 17, 2008 at 08:44:40AM +0100, Johannes Sixt <j.sixt@viscovery.net> wrote:
> > > This is true, but having the executable bit is necessary as well. I
> > > think it would be better to just append this requirement instead of
> > > replacing the old one with this.
> > 
> > Markus's proposed new wording is correct because the .sample hooks *are*
> > already executable.
> 
> I thought about the following situation: The user reads the
> documentation while working in an older repo (initialized a few versions
> ago). S/he sees that the .sample suffix is already missing, so s/he
> assumes that the hook is already active. Which is not true, because the
> +x bit is missing.

Valid point, I think, but not critical in this case, since the patch only affected gitrepository-layout(5) and gitglossary(7).

When you want to learn how to use hooks, you will probably rather read githooks(5), where the need for the executable bit is not even explicitly mentioned. Maybe it should be added there?

Markus