Re: [PATCH] Documentation: fix description for enabling hooks
- From
Miklos Vajna <vmiklos@frugalware.org>
- Date
- Dec 17, 2008, 14:36 UTC
- Message-ID
- <20081217143627.GB5691@genesis.frugalware.org>
- In-Reply-To
- <4948ADE8.2050804@viscovery.net>
On Wed, Dec 17, 2008 at 08:44:40AM +0100, Johannes Sixt <j.sixt@viscovery.net> wrote:
Show 6 quoted lines
> > This is true, but having the executable bit is necessary as well. I > > think it would be better to just append this requirement instead of > > replacing the old one with this. > > Markus's proposed new wording is correct because the .sample hooks *are* > already executable.
I thought about the following situation: The user reads the documentation while working in an older repo (initialized a few versions ago). S/he sees that the .sample suffix is already missing, so s/he assumes that the hook is already active. Which is not true, because the +x bit is missing.