# [PATCH] Documentation: fix description for enabling hooks 6 messages from 2008-12-17 to 2008-12-17. Participants: Markus Heidelberg, Miklos Vajna, Johannes Sixt. Thread: https://gitlist.dev/t/16760 ## Markus Heidelberg, 2008-12-17 02:59 Subject: [PATCH] Documentation: fix description for enabling hooks Message-ID: <200812170359.24109.markus.heidelberg@web.de> URL: https://gitlist.dev/e/200812170359.24109.markus.heidelberg%40web.de ``` Since f98f8cb (Ship sample hooks with .sample suffix, 2008-06-24) hooks are not enabled by making them executable anymore, but by removing the '.sample' suffix from the filename. Signed-off-by: Markus Heidelberg --- Documentation/gitrepository-layout.txt | 3 ++- Documentation/glossary-content.txt | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/gitrepository-layout.txt b/Documentation/gitrepository-layout.txt index a969b3f..1befca9 100644 --- a/Documentation/gitrepository-layout.txt +++ b/Documentation/gitrepository-layout.txt @@ -134,7 +134,8 @@ hooks:: Hooks are customization scripts used by various git commands. A handful of sample hooks are installed when 'git-init' is run, but all of them are disabled by - default. To enable, they need to be made executable. + default. To enable, the `.sample` suffix has to be + removed from the filename by renaming. Read linkgit:githooks[5] for more details about each hook. diff --git a/Documentation/glossary-content.txt b/Documentation/glossary-content.txt index 9b4a4f4..9afca75 100644 --- a/Documentation/glossary-content.txt +++ b/Documentation/glossary-content.txt @@ -183,7 +183,8 @@ to point at the new commit. and potentially aborted, and allow for a post-notification after the operation is done. The hook scripts are found in the `$GIT_DIR/hooks/` directory, and are enabled by simply - making them executable. + removing the `.sample` suffix from the filename. In earlier versions + of git you had to make them executable. [[def_index]]index:: A collection of files with stat information, whose contents are stored -- 1.6.1.rc3.23.gaf48b ``` ## Miklos Vajna, 2008-12-17 04:13 Subject: Re: [PATCH] Documentation: fix description for enabling hooks Message-ID: <20081217041312.GZ5691@genesis.frugalware.org> URL: https://gitlist.dev/e/20081217041312.GZ5691%40genesis.frugalware.org In-Reply-To: <200812170359.24109.markus.heidelberg@web.de> ``` On Wed, Dec 17, 2008 at 03:59:23AM +0100, Markus Heidelberg wrote: > Since f98f8cb (Ship sample hooks with .sample suffix, 2008-06-24) hooks > are not enabled by making them executable anymore, but by removing the > '.sample' suffix from the filename. This is true, but having the executable bit is necessary as well. I think it would be better to just append this requirement instead of replacing the old one with this. ``` ## Johannes Sixt, 2008-12-17 07:44 Subject: Re: [PATCH] Documentation: fix description for enabling hooks Message-ID: <4948ADE8.2050804@viscovery.net> URL: https://gitlist.dev/e/4948ADE8.2050804%40viscovery.net In-Reply-To: <20081217041312.GZ5691@genesis.frugalware.org> ``` Miklos Vajna schrieb: > On Wed, Dec 17, 2008 at 03:59:23AM +0100, Markus Heidelberg wrote: >> Since f98f8cb (Ship sample hooks with .sample suffix, 2008-06-24) hooks >> are not enabled by making them executable anymore, but by removing the >> '.sample' suffix from the filename. > > This is true, but having the executable bit is necessary as well. I > think it would be better to just append this requirement instead of > replacing the old one with this. Markus's proposed new wording is correct because the .sample hooks *are* already executable. -- Hannes ``` ## Miklos Vajna, 2008-12-17 14:36 Subject: Re: [PATCH] Documentation: fix description for enabling hooks Message-ID: <20081217143627.GB5691@genesis.frugalware.org> URL: https://gitlist.dev/e/20081217143627.GB5691%40genesis.frugalware.org In-Reply-To: <4948ADE8.2050804@viscovery.net> ``` On Wed, Dec 17, 2008 at 08:44:40AM +0100, Johannes Sixt wrote: > > This is true, but having the executable bit is necessary as well. I > > think it would be better to just append this requirement instead of > > replacing the old one with this. > > Markus's proposed new wording is correct because the .sample hooks *are* > already executable. I thought about the following situation: The user reads the documentation while working in an older repo (initialized a few versions ago). S/he sees that the .sample suffix is already missing, so s/he assumes that the hook is already active. Which is not true, because the +x bit is missing. ``` ## Markus Heidelberg, 2008-12-17 19:55 Subject: Re: [PATCH] Documentation: fix description for enabling hooks Message-ID: <200812172055.45905.markus.heidelberg@web.de> URL: https://gitlist.dev/e/200812172055.45905.markus.heidelberg%40web.de In-Reply-To: <20081217143627.GB5691@genesis.frugalware.org> ``` Miklos Vajna, 17.12.2008: > On Wed, Dec 17, 2008 at 08:44:40AM +0100, Johannes Sixt wrote: > > > This is true, but having the executable bit is necessary as well. I > > > think it would be better to just append this requirement instead of > > > replacing the old one with this. > > > > Markus's proposed new wording is correct because the .sample hooks *are* > > already executable. > > I thought about the following situation: The user reads the > documentation while working in an older repo (initialized a few versions > ago). S/he sees that the .sample suffix is already missing, so s/he > assumes that the hook is already active. Which is not true, because the > +x bit is missing. Valid point, I think, but not critical in this case, since the patch only affected gitrepository-layout(5) and gitglossary(7). When you want to learn how to use hooks, you will probably rather read githooks(5), where the need for the executable bit is not even explicitly mentioned. Maybe it should be added there? Markus ``` ## Miklos Vajna, 2008-12-17 21:29 Subject: [PATCH] githooks documentation: add a note about the +x mode Message-ID: <1229549346-17863-1-git-send-email-vmiklos@frugalware.org> URL: https://gitlist.dev/e/1229549346-17863-1-git-send-email-vmiklos%40frugalware.org In-Reply-To: <200812172055.45905.markus.heidelberg@web.de> ``` In a freshly initialized repo it is only necessary to rename the .sample hooks, but when using older repos (initialized with older git init) enabled the +x mode is still necessary - docuement this. Signed-off-by: Miklos Vajna --- On Wed, Dec 17, 2008 at 08:55:45PM +0100, Markus Heidelberg wrote: > When you want to learn how to use hooks, you will probably rather read > githooks(5), where the need for the executable bit is not even > explicitly mentioned. Maybe it should be added there? I think so. Documentation/githooks.txt | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt index 5faaaa5..cfdae1e 100644 --- a/Documentation/githooks.txt +++ b/Documentation/githooks.txt @@ -20,6 +20,10 @@ directory to trigger action at certain points. When all disabled. To enable a hook, rename it by removing its `.sample` suffix. +NOTE: It is also a requirement for a given hook to be executable. +However - in a freshly initialized repository - the `.sample` files are +executable by default. + This document describes the currently defined hooks. applypatch-msg -- 1.6.1.rc1.35.gae26e.dirty ```