threads / discuss / 16623

Re: [RFCv4 1/3] gitweb: add patch view

Subject: Re: [RFCv4 1/3] gitweb: add patch view

## tl;dr

One message between Dec 7, 2008 and Dec 7, 2008.

replies: 0people: 1as markdown or json

Giuseppe Bilotta· Dec 7, 2008, 09:52 UTC · lore
On Sun, Dec 7, 2008 at 7:04 AM, Matt Kraai <kraai@ftbfs.org> wrote:
Show 5 quoted lines
> Howdy,
>
> Why do you check $patch_max at the start of git_commitdiff instead of
> at the start of hunk which opens git-format-patch?  It seems like it
> would be clearer to check it later, at some small loss of efficiency.

Subsequent patches use the check to add a link to the nav bar, so it reduces code shift from patch to patch 8-)

-- 
Giuseppe "Oblomov" Bilotta

← back to recent threads