# Re: [RFCv4 1/3] gitweb: add patch view 1 messages from 2008-12-07 to 2008-12-07. Participants: Giuseppe Bilotta. Thread: https://gitlist.dev/t/16623 ## Giuseppe Bilotta, 2008-12-07 09:52 Subject: Re: [RFCv4 1/3] gitweb: add patch view Message-ID: URL: https://gitlist.dev/e/cb7bb73a0812070152j3c7ecc51r9f19523cfef44d39%40mail.gmail.com In-Reply-To: <20081207060430.GE4357@ftbfs.org> ``` On Sun, Dec 7, 2008 at 7:04 AM, Matt Kraai wrote: > Howdy, > > Why do you check $patch_max at the start of git_commitdiff instead of > at the start of hunk which opens git-format-patch? It seems like it > would be clearer to check it later, at some small loss of efficiency. Subsequent patches use the check to add a link to the nav bar, so it reduces code shift from patch to patch 8-) -- Giuseppe "Oblomov" Bilotta ```