{"thread":{"id":"16623","subject":"Re: [RFCv4 1/3] gitweb: add patch view","startedAt":"2008-12-07T09:52:38Z","lastAt":"2008-12-07T09:52:38Z","messageCount":1,"participants":["Giuseppe Bilotta"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"97297","messageId":"cb7bb73a0812070152j3c7ecc51r9f19523cfef44d39@mail.gmail.com","threadId":"16623","inReplyTo":"20081207060430.GE4357@ftbfs.org","subject":"Re: [RFCv4 1/3] gitweb: add patch view","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2008-12-07T09:52:38Z","receivedAt":"2008-12-07T09:52:38Z","isPatch":false,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"On Sun, Dec 7, 2008 at 7:04 AM, Matt Kraai <kraai@ftbfs.org> wrote:\n> Howdy,\n>\n> Why do you check $patch_max at the start of git_commitdiff instead of\n> at the start of hunk which opens git-format-patch?  It seems like it\n> would be clearer to check it later, at some small loss of efficiency.\n\nSubsequent patches use the check to add a link to the nav bar, so it\nreduces code shift from patch to patch 8-)\n\n-- \nGiuseppe \"Oblomov\" Bilotta\n"}]}