git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFCv4 1/3] gitweb: add patch view

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Dec 7, 2008, 09:52 UTC
Message-ID
<cb7bb73a0812070152j3c7ecc51r9f19523cfef44d39@mail.gmail.com>
In-Reply-To
<20081207060430.GE4357@ftbfs.org>
On Sun, Dec 7, 2008 at 7:04 AM, Matt Kraai <kraai@ftbfs.org> wrote:
Show 5 quoted lines
> Howdy,
>
> Why do you check $patch_max at the start of git_commitdiff instead of
> at the start of hunk which opens git-format-patch?  It seems like it
> would be clearer to check it later, at some small loss of efficiency.

Subsequent patches use the check to add a link to the nav bar, so it reduces code shift from patch to patch 8-)

-- 
Giuseppe "Oblomov" Bilotta
Message 1 of 1 in “Re: [RFCv4 1/3] gitweb: add patch view”
  1. Giuseppe BilottaDec 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.