Re: [PATCH] explicitly set LANG to 'C' in for guilt run-tests
On Mon, Sep 29, 2008 at 10:25:48PM +0200, Mikael Magnusson wrote:
Show 33 quoted lines
> 2008/9/29 Scott Moser <smoser@brickies.net>:
> > The output of guilt's run-tests is dependent on LANG due to reliance on a
> > given sorting algorithm. Currently, the test '052' will fail if LANG is
> > set to 'en_US.UTF-8' (and likely others values).
> >
> > Remove the assumption by explicitly setting this in run-tests.
> >
> > Signed-off-by: Scott Moser <smoser@brickies.net>
> > ---
> > regression/run-tests | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/regression/run-tests b/regression/run-tests
> > index 8f572eb..945150b 100755
> > --- a/regression/run-tests
> > +++ b/regression/run-tests
> > @@ -2,6 +2,7 @@
> >
> > export REG_DIR="$PWD"
> > export PATH="$PWD/bin:$PATH"
> > +export LANG=C
> >
> > source scaffold
> >
> > --
> > 1.5.6.3
>
> If I'm not mistaken, $LANG is used as the ultimate fallback, while LC_ALL is
> the one that overrides all others, so you probably want to set LC_ALL. I'm
> unsure which off the specific ones would apply here, but very likely it's
> LC_COLLATE. In other words, if LC_ALL is set, it is used, otherwise if
> LC_COLLATE is set it is used, otherwise if LANG is set, it is used,
> otherwise, "POSIX" is used.
IIRC, my devel system has all of them set to UTF8, _except_ LC_COLLATE (I like the case sensitive sort of filenames in ls(1)) which I have set to "C". So chances are that the minimum required is LC_COLLATE=C, but overriding everything might be safer overall.
Josef 'Jeff' Sipek.
--
Penguin : Linux version 2.6.25.4 on an i386 machine (6135.73 BogoMips).