{"thread":{"id":"15710","subject":"[PATCH] explicitly set LANG to 'C' in for guilt run-tests","startedAt":"2008-09-29T18:51:12Z","lastAt":"2008-09-30T04:42:58Z","messageCount":5,"participants":["Scott Moser","Mikael Magnusson","Josef Jeff Sipek","Josef 'Jeff' Sipek"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"91874","messageId":"1222714272-9557-1-git-send-email-smoser@brickies.net","threadId":"15710","inReplyTo":null,"subject":"[PATCH] explicitly set LANG to 'C' in for guilt run-tests","fromName":"Scott Moser","fromEmail":"smoser@brickies.net","sentAt":"2008-09-29T18:51:12Z","receivedAt":"2008-09-29T18:51:12Z","isPatch":true,"sender":{"key":"smoser@brickies.net","avatar":"https://gravatar.com/avatar/72ac028bd8501889de97ffa6dda78e0f3c4cd15830aa09c2c11cdc117130f83c?d=mp&s=160"},"body":"The output of guilt's run-tests is dependent on LANG due to reliance on a\ngiven sorting algorithm. Currently, the test '052' will fail if LANG is\nset to 'en_US.UTF-8' (and likely others values).\n\nRemove the assumption by explicitly setting this in run-tests.\n\nSigned-off-by: Scott Moser \n---\n regression/run-tests | 1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/regression/run-tests b/regression/run-tests\nindex 8f572eb..945150b 100755\n--- a/regression/run-tests\n+++ b/regression/run-tests\n@@ -2,6 +2,7 @@\n \n export REG_DIR=\"$PWD\"\n export PATH=\"$PWD/bin:$PATH\"\n+export LANG=C\n \n source scaffold\n \n-- \n1.5.6.3\n"},{"id":"91880","messageId":"237967ef0809291325p7a0e3581vac348a1e99dbd4ed@mail.gmail.com","threadId":"15710","inReplyTo":"1222714272-9557-1-git-send-email-smoser@brickies.net","subject":"Re: [PATCH] explicitly set LANG to 'C' in for guilt run-tests","fromName":"Mikael Magnusson","fromEmail":"mikachu@gmail.com","sentAt":"2008-09-29T20:25:48Z","receivedAt":"2008-09-29T20:25:48Z","isPatch":true,"sender":{"key":"mikachu@gmail.com","avatar":null},"body":"2008/9/29 Scott Moser :\n> The output of guilt's run-tests is dependent on LANG due to reliance on a\n> given sorting algorithm. Currently, the test '052' will fail if LANG is\n> set to 'en_US.UTF-8' (and likely others values).\n>\n> Remove the assumption by explicitly setting this in run-tests.\n>\n> Signed-off-by: Scott Moser \n> ---\n> regression/run-tests | 1 +\n> 1 files changed, 1 insertions(+), 0 deletions(-)\n>\n> diff --git a/regression/run-tests b/regression/run-tests\n> index 8f572eb..945150b 100755\n> --- a/regression/run-tests\n> +++ b/regression/run-tests\n> @@ -2,6 +2,7 @@\n>\n> export REG_DIR=\"$PWD\"\n> export PATH=\"$PWD/bin:$PATH\"\n> +export LANG=C\n>\n> source scaffold\n>\n> --\n> 1.5.6.3\n\nIf I'm not mistaken, $LANG is used as the ultimate fallback, while LC_ALL is\nthe one that overrides all others, so you probably want to set LC_ALL. I'm\nunsure which off the specific ones would apply here, but very likely it's\nLC_COLLATE. In other words, if LC_ALL is set, it is used, otherwise if\nLC_COLLATE is set it is used, otherwise if LANG is set, it is used,\notherwise, \"POSIX\" is used.\n\n-- \nMikael Magnusson\n"},{"id":"91881","messageId":"20080929204958.GD31590@josefsipek.net","threadId":"15710","inReplyTo":"237967ef0809291325p7a0e3581vac348a1e99dbd4ed@mail.gmail.com","subject":"Re: [PATCH] explicitly set LANG to 'C' in for guilt run-tests","fromName":"Josef Jeff Sipek","fromEmail":"jsipek@cs.sunysb.edu","sentAt":"2008-09-29T20:49:58Z","receivedAt":"2008-09-29T20:49:58Z","isPatch":true,"sender":{"key":"jsipek@cs.sunysb.edu","avatar":null},"body":"On Mon, Sep 29, 2008 at 10:25:48PM +0200, Mikael Magnusson wrote:\n> 2008/9/29 Scott Moser :\n> > The output of guilt's run-tests is dependent on LANG due to reliance on a\n> > given sorting algorithm. Currently, the test '052' will fail if LANG is\n> > set to 'en_US.UTF-8' (and likely others values).\n> >\n> > Remove the assumption by explicitly setting this in run-tests.\n> >\n> > Signed-off-by: Scott Moser \n> > ---\n> > regression/run-tests | 1 +\n> > 1 files changed, 1 insertions(+), 0 deletions(-)\n> >\n> > diff --git a/regression/run-tests b/regression/run-tests\n> > index 8f572eb..945150b 100755\n> > --- a/regression/run-tests\n> > +++ b/regression/run-tests\n> > @@ -2,6 +2,7 @@\n> >\n> > export REG_DIR=\"$PWD\"\n> > export PATH=\"$PWD/bin:$PATH\"\n> > +export LANG=C\n> >\n> > source scaffold\n> >\n> > --\n> > 1.5.6.3\n> \n> If I'm not mistaken, $LANG is used as the ultimate fallback, while LC_ALL is\n> the one that overrides all others, so you probably want to set LC_ALL. I'm\n> unsure which off the specific ones would apply here, but very likely it's\n> LC_COLLATE. In other words, if LC_ALL is set, it is used, otherwise if\n> LC_COLLATE is set it is used, otherwise if LANG is set, it is used,\n> otherwise, \"POSIX\" is used.\n\nIIRC, my devel system has all of them set to UTF8, _except_ LC_COLLATE (I\nlike the case sensitive sort of filenames in ls(1)) which I have set to \"C\".\nSo chances are that the minimum required is LC_COLLATE=C, but overriding\neverything might be safer overall.\n\nJosef 'Jeff' Sipek.\n\n-- \nPenguin : Linux version 2.6.25.4 on an i386 machine (6135.73 BogoMips).\n"},{"id":"91882","messageId":"alpine.DEB.1.00.0809291700130.935@brickies","threadId":"15710","inReplyTo":"20080929204958.GD31590@josefsipek.net","subject":"Re: [PATCH] explicitly set LANG to 'C' in for guilt run-tests","fromName":"Scott Moser","fromEmail":"smoser@brickies.net","sentAt":"2008-09-29T21:01:45Z","receivedAt":"2008-09-29T21:01:45Z","isPatch":true,"sender":{"key":"smoser@brickies.net","avatar":"https://gravatar.com/avatar/72ac028bd8501889de97ffa6dda78e0f3c4cd15830aa09c2c11cdc117130f83c?d=mp&s=160"},"body":"On Mon, 29 Sep 2008, Josef Jeff Sipek wrote:\n> > If I'm not mistaken, $LANG is used as the ultimate fallback, while LC_ALL is\n> > the one that overrides all others, so you probably want to set LC_ALL. I'm\n> > unsure which off the specific ones would apply here, but very likely it's\n> > LC_COLLATE. In other words, if LC_ALL is set, it is used, otherwise if\n> > LC_COLLATE is set it is used, otherwise if LANG is set, it is used,\n> > otherwise, \"POSIX\" is used.\n>\n> IIRC, my devel system has all of them set to UTF8, _except_ LC_COLLATE (I\n> like the case sensitive sort of filenames in ls(1)) which I have set to \"C\".\n> So chances are that the minimum required is LC_COLLATE=C, but overriding\n> everything might be safer overall.\n>\n\nYeah, LC_ALL I sprobably correct. I'm not very \"LANG\" aware at all. I\njust noticed that test 052 didn't run on my system, and figured out that\nwas why.\n\nYou want a re-send of this patch with LC_ALL ? Or do you want to make\nthe modification yourself and apply?\n\nScott\n"},{"id":"91892","messageId":"20080930044258.GF32444@josefsipek.net","threadId":"15710","inReplyTo":"237967ef0809291325p7a0e3581vac348a1e99dbd4ed@mail.gmail.com","subject":"Re: [PATCH] explicitly set LANG to 'C' in for guilt run-tests","fromName":"Josef 'Jeff' Sipek","fromEmail":"jeffpc@josefsipek.net","sentAt":"2008-09-30T04:42:58Z","receivedAt":"2008-09-30T04:42:58Z","isPatch":true,"sender":{"key":"jeffpc@josefsipek.net","avatar":null},"body":"On Mon, Sep 29, 2008 at 10:25:48PM +0200, Mikael Magnusson wrote:\n...\n> If I'm not mistaken, $LANG is used as the ultimate fallback, while LC_ALL is\n> the one that overrides all others, so you probably want to set LC_ALL. I'm\n> unsure which off the specific ones would apply here, but very likely it's\n> LC_COLLATE. In other words, if LC_ALL is set, it is used, otherwise if\n> LC_COLLATE is set it is used, otherwise if LANG is set, it is used,\n> otherwise, \"POSIX\" is used.\n\nI fixed up the patch to set LC_ALL instead, and committed it.\n\nThanks,\n\nJosef 'Jeff' Sipek.\n\n-- \nHumans were created by water to transport it upward.\n"}]}