# [PATCH] explicitly set LANG to 'C' in for guilt run-tests 5 messages from 2008-09-29 to 2008-09-30. Participants: Scott Moser, Mikael Magnusson, Josef Jeff Sipek, Josef 'Jeff' Sipek. Thread: https://gitlist.dev/t/15710 ## Scott Moser, 2008-09-29 18:51 Subject: [PATCH] explicitly set LANG to 'C' in for guilt run-tests Message-ID: <1222714272-9557-1-git-send-email-smoser@brickies.net> URL: https://gitlist.dev/e/1222714272-9557-1-git-send-email-smoser%40brickies.net ``` The output of guilt's run-tests is dependent on LANG due to reliance on a given sorting algorithm. Currently, the test '052' will fail if LANG is set to 'en_US.UTF-8' (and likely others values). Remove the assumption by explicitly setting this in run-tests. Signed-off-by: Scott Moser --- regression/run-tests | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/regression/run-tests b/regression/run-tests index 8f572eb..945150b 100755 --- a/regression/run-tests +++ b/regression/run-tests @@ -2,6 +2,7 @@ export REG_DIR="$PWD" export PATH="$PWD/bin:$PATH" +export LANG=C source scaffold -- 1.5.6.3 ``` ## Mikael Magnusson, 2008-09-29 20:25 Subject: Re: [PATCH] explicitly set LANG to 'C' in for guilt run-tests Message-ID: <237967ef0809291325p7a0e3581vac348a1e99dbd4ed@mail.gmail.com> URL: https://gitlist.dev/e/237967ef0809291325p7a0e3581vac348a1e99dbd4ed%40mail.gmail.com In-Reply-To: <1222714272-9557-1-git-send-email-smoser@brickies.net> ``` 2008/9/29 Scott Moser : > The output of guilt's run-tests is dependent on LANG due to reliance on a > given sorting algorithm. Currently, the test '052' will fail if LANG is > set to 'en_US.UTF-8' (and likely others values). > > Remove the assumption by explicitly setting this in run-tests. > > Signed-off-by: Scott Moser > --- > regression/run-tests | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/regression/run-tests b/regression/run-tests > index 8f572eb..945150b 100755 > --- a/regression/run-tests > +++ b/regression/run-tests > @@ -2,6 +2,7 @@ > > export REG_DIR="$PWD" > export PATH="$PWD/bin:$PATH" > +export LANG=C > > source scaffold > > -- > 1.5.6.3 If I'm not mistaken, $LANG is used as the ultimate fallback, while LC_ALL is the one that overrides all others, so you probably want to set LC_ALL. I'm unsure which off the specific ones would apply here, but very likely it's LC_COLLATE. In other words, if LC_ALL is set, it is used, otherwise if LC_COLLATE is set it is used, otherwise if LANG is set, it is used, otherwise, "POSIX" is used. -- Mikael Magnusson ``` ## Josef Jeff Sipek, 2008-09-29 20:49 Subject: Re: [PATCH] explicitly set LANG to 'C' in for guilt run-tests Message-ID: <20080929204958.GD31590@josefsipek.net> URL: https://gitlist.dev/e/20080929204958.GD31590%40josefsipek.net In-Reply-To: <237967ef0809291325p7a0e3581vac348a1e99dbd4ed@mail.gmail.com> ``` On Mon, Sep 29, 2008 at 10:25:48PM +0200, Mikael Magnusson wrote: > 2008/9/29 Scott Moser : > > The output of guilt's run-tests is dependent on LANG due to reliance on a > > given sorting algorithm. Currently, the test '052' will fail if LANG is > > set to 'en_US.UTF-8' (and likely others values). > > > > Remove the assumption by explicitly setting this in run-tests. > > > > Signed-off-by: Scott Moser > > --- > > regression/run-tests | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/regression/run-tests b/regression/run-tests > > index 8f572eb..945150b 100755 > > --- a/regression/run-tests > > +++ b/regression/run-tests > > @@ -2,6 +2,7 @@ > > > > export REG_DIR="$PWD" > > export PATH="$PWD/bin:$PATH" > > +export LANG=C > > > > source scaffold > > > > -- > > 1.5.6.3 > > If I'm not mistaken, $LANG is used as the ultimate fallback, while LC_ALL is > the one that overrides all others, so you probably want to set LC_ALL. I'm > unsure which off the specific ones would apply here, but very likely it's > LC_COLLATE. In other words, if LC_ALL is set, it is used, otherwise if > LC_COLLATE is set it is used, otherwise if LANG is set, it is used, > otherwise, "POSIX" is used. IIRC, my devel system has all of them set to UTF8, _except_ LC_COLLATE (I like the case sensitive sort of filenames in ls(1)) which I have set to "C". So chances are that the minimum required is LC_COLLATE=C, but overriding everything might be safer overall. Josef 'Jeff' Sipek. -- Penguin : Linux version 2.6.25.4 on an i386 machine (6135.73 BogoMips). ``` ## Scott Moser, 2008-09-29 21:01 Subject: Re: [PATCH] explicitly set LANG to 'C' in for guilt run-tests Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.0809291700130.935%40brickies In-Reply-To: <20080929204958.GD31590@josefsipek.net> ``` On Mon, 29 Sep 2008, Josef Jeff Sipek wrote: > > If I'm not mistaken, $LANG is used as the ultimate fallback, while LC_ALL is > > the one that overrides all others, so you probably want to set LC_ALL. I'm > > unsure which off the specific ones would apply here, but very likely it's > > LC_COLLATE. In other words, if LC_ALL is set, it is used, otherwise if > > LC_COLLATE is set it is used, otherwise if LANG is set, it is used, > > otherwise, "POSIX" is used. > > IIRC, my devel system has all of them set to UTF8, _except_ LC_COLLATE (I > like the case sensitive sort of filenames in ls(1)) which I have set to "C". > So chances are that the minimum required is LC_COLLATE=C, but overriding > everything might be safer overall. > Yeah, LC_ALL I sprobably correct. I'm not very "LANG" aware at all. I just noticed that test 052 didn't run on my system, and figured out that was why. You want a re-send of this patch with LC_ALL ? Or do you want to make the modification yourself and apply? Scott ``` ## Josef 'Jeff' Sipek, 2008-09-30 04:42 Subject: Re: [PATCH] explicitly set LANG to 'C' in for guilt run-tests Message-ID: <20080930044258.GF32444@josefsipek.net> URL: https://gitlist.dev/e/20080930044258.GF32444%40josefsipek.net In-Reply-To: <237967ef0809291325p7a0e3581vac348a1e99dbd4ed@mail.gmail.com> ``` On Mon, Sep 29, 2008 at 10:25:48PM +0200, Mikael Magnusson wrote: ... > If I'm not mistaken, $LANG is used as the ultimate fallback, while LC_ALL is > the one that overrides all others, so you probably want to set LC_ALL. I'm > unsure which off the specific ones would apply here, but very likely it's > LC_COLLATE. In other words, if LC_ALL is set, it is used, otherwise if > LC_COLLATE is set it is used, otherwise if LANG is set, it is used, > otherwise, "POSIX" is used. I fixed up the patch to set LC_ALL instead, and committed it. Thanks, Josef 'Jeff' Sipek. -- Humans were created by water to transport it upward. ```