Re: [PATCH] explicitly set LANG to 'C' in for guilt run-tests

From: Mikael Magnusson <mikachu@gmail.com>
Date: Sep 29, 2008, 20:25 UTC
Message-ID: <237967ef0809291325p7a0e3581vac348a1e99dbd4ed@mail.gmail.com>
In-Reply-To: <1222714272-9557-1-git-send-email-smoser@brickies.net>

2008/9/29 Scott Moser <smoser@brickies.net>:

Show 25 quoted lines

> The output of guilt's run-tests is dependent on LANG due to reliance on a
> given sorting algorithm. Currently, the test '052' will fail if LANG is
> set to 'en_US.UTF-8' (and likely others values).
>
> Remove the assumption by explicitly setting this in run-tests.
>
> Signed-off-by: Scott Moser <smoser@brickies.net>
> ---
>  regression/run-tests |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/regression/run-tests b/regression/run-tests
> index 8f572eb..945150b 100755
> --- a/regression/run-tests
> +++ b/regression/run-tests
> @@ -2,6 +2,7 @@
>
>  export REG_DIR="$PWD"
>  export PATH="$PWD/bin:$PATH"
> +export LANG=C
>
>  source scaffold
>
> --
> 1.5.6.3

If I'm not mistaken, $LANG is used as the ultimate fallback, while LC_ALL is the one that overrides all others, so you probably want to set LC_ALL. I'm unsure which off the specific ones would apply here, but very likely it's LC_COLLATE. In other words, if LC_ALL is set, it is used, otherwise if LC_COLLATE is set it is used, otherwise if LANG is set, it is used, otherwise, "POSIX" is used.

-- 
Mikael Magnusson