threads / patch / 15146

patchgit-p4: Fix one-liner in p4_write_pipe function.

Subject: [PATCH] git-p4: Fix one-liner in p4_write_pipe function.

## tl;dr

4 messages between Aug 21, 2008 and Aug 25, 2008. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Tor Arvid Lund· Aug 21, 2008, 21:11 UTC · lore
The function built a p4 command string via the p4_build_cmd function, but
ignored the result.
---
 contrib/fast-import/git-p4 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to contrib/fast-import/git-p4 +1 −1
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index f9865b4..46136d4 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -76,7 +76,7 @@ def write_pipe(c, str):
 
 def p4_write_pipe(c, str):
     real_cmd = p4_build_cmd(c)
-    return write_pipe(c, str)
+    return write_pipe(real_cmd, str)
 
 def read_pipe(c, ignore_error=False):
     if verbose:

-- 
1.6.0.GIT
Tor Arvid Lund· Aug 22, 2008, 07:23 UTC · re: Junio C Hamano · lore

Re: [PATCH] git-p4: Fix one-liner in p4_write_pipe function.

On Fri, Aug 22, 2008 at 8:21 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Looks obviously correct.  Mind if I forge your sign-off?
>

Heh, that'll be fine. I don't submit patches that often, so I just forgot - sorry ;-)

-Tor Arvid-
Anand Kumria· Aug 25, 2008, 20:41 UTC · re: Tor Arvid Lund · lore

Re: [PATCH] git-p4: Fix one-liner in p4_write_pipe function.

On Thu, 21 Aug 2008 23:11:40 +0200, Tor Arvid Lund wrote:
> The function built a p4 command string via the p4_build_cmd function,
> but ignored the result.
Opps - thanks for catching this.
Anand

← back to recent threads