{"thread":{"id":"15146","subject":"[PATCH] git-p4: Fix one-liner in p4_write_pipe function.","startedAt":"2008-08-21T21:11:40Z","lastAt":"2008-08-25T20:41:11Z","messageCount":4,"participants":["Tor Arvid Lund","Junio C Hamano","Anand Kumria"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"88043","messageId":"1219353100-1692-1-git-send-email-torarvid@gmail.com","threadId":"15146","inReplyTo":null,"subject":"[PATCH] git-p4: Fix one-liner in p4_write_pipe function.","fromName":"Tor Arvid Lund","fromEmail":"torarvid@gmail.com","sentAt":"2008-08-21T21:11:40Z","receivedAt":"2008-08-21T21:11:40Z","isPatch":true,"sender":{"key":"torarvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/439758?v=4"},"body":"The function built a p4 command string via the p4_build_cmd function, but\nignored the result.\n---\n contrib/fast-import/git-p4 |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4\nindex f9865b4..46136d4 100755\n--- a/contrib/fast-import/git-p4\n+++ b/contrib/fast-import/git-p4\n@@ -76,7 +76,7 @@ def write_pipe(c, str):\n \n def p4_write_pipe(c, str):\n     real_cmd = p4_build_cmd(c)\n-    return write_pipe(c, str)\n+    return write_pipe(real_cmd, str)\n \n def read_pipe(c, ignore_error=False):\n     if verbose:\n-- \n1.6.0.GIT\n"},{"id":"88090","messageId":"7vd4k1d0yk.fsf@gitster.siamese.dyndns.org","threadId":"15146","inReplyTo":"1219353100-1692-1-git-send-email-torarvid@gmail.com","subject":"Re: [PATCH] git-p4: Fix one-liner in p4_write_pipe function.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-08-22T06:21:23Z","receivedAt":"2008-08-22T06:21:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Looks obviously correct.  Mind if I forge your sign-off?\n"},{"id":"88095","messageId":"1a6be5fa0808220023s1df3bac7u90a5103cc4a4a788@mail.gmail.com","threadId":"15146","inReplyTo":"7vd4k1d0yk.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] git-p4: Fix one-liner in p4_write_pipe function.","fromName":"Tor Arvid Lund","fromEmail":"torarvid@gmail.com","sentAt":"2008-08-22T07:23:48Z","receivedAt":"2008-08-22T07:23:48Z","isPatch":true,"sender":{"key":"torarvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/439758?v=4"},"body":"On Fri, Aug 22, 2008 at 8:21 AM, Junio C Hamano <gitster@pobox.com> wrote:\n> Looks obviously correct.  Mind if I forge your sign-off?\n>\n\nHeh, that'll be fine. I don't submit patches that often, so I just\nforgot - sorry ;-)\n\n-Tor Arvid-\n"},{"id":"88504","messageId":"g8v5d7$apj$1@ger.gmane.org","threadId":"15146","inReplyTo":"1219353100-1692-1-git-send-email-torarvid@gmail.com","subject":"Re: [PATCH] git-p4: Fix one-liner in p4_write_pipe function.","fromName":"Anand Kumria","fromEmail":"wildfire@progsoc.org","sentAt":"2008-08-25T20:41:11Z","receivedAt":"2008-08-25T20:41:11Z","isPatch":true,"sender":{"key":"wildfire@progsoc.org","avatar":null},"body":"On Thu, 21 Aug 2008 23:11:40 +0200, Tor Arvid Lund wrote:\n\n> The function built a p4 command string via the p4_build_cmd function,\n> but ignored the result.\n\nOpps - thanks for catching this.\n\nAnand\n"}]}