# [PATCH] git-p4: Fix one-liner in p4_write_pipe function. 4 messages from 2008-08-21 to 2008-08-25. Participants: Tor Arvid Lund, Junio C Hamano, Anand Kumria. Thread: https://gitlist.dev/t/15146 ## Tor Arvid Lund, 2008-08-21 21:11 Subject: [PATCH] git-p4: Fix one-liner in p4_write_pipe function. Message-ID: <1219353100-1692-1-git-send-email-torarvid@gmail.com> URL: https://gitlist.dev/e/1219353100-1692-1-git-send-email-torarvid%40gmail.com ``` The function built a p4 command string via the p4_build_cmd function, but ignored the result. --- contrib/fast-import/git-p4 | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 index f9865b4..46136d4 100755 --- a/contrib/fast-import/git-p4 +++ b/contrib/fast-import/git-p4 @@ -76,7 +76,7 @@ def write_pipe(c, str): def p4_write_pipe(c, str): real_cmd = p4_build_cmd(c) - return write_pipe(c, str) + return write_pipe(real_cmd, str) def read_pipe(c, ignore_error=False): if verbose: -- 1.6.0.GIT ``` ## Junio C Hamano, 2008-08-22 06:21 Subject: Re: [PATCH] git-p4: Fix one-liner in p4_write_pipe function. Message-ID: <7vd4k1d0yk.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vd4k1d0yk.fsf%40gitster.siamese.dyndns.org In-Reply-To: <1219353100-1692-1-git-send-email-torarvid@gmail.com> ``` Looks obviously correct. Mind if I forge your sign-off? ``` ## Tor Arvid Lund, 2008-08-22 07:23 Subject: Re: [PATCH] git-p4: Fix one-liner in p4_write_pipe function. Message-ID: <1a6be5fa0808220023s1df3bac7u90a5103cc4a4a788@mail.gmail.com> URL: https://gitlist.dev/e/1a6be5fa0808220023s1df3bac7u90a5103cc4a4a788%40mail.gmail.com In-Reply-To: <7vd4k1d0yk.fsf@gitster.siamese.dyndns.org> ``` On Fri, Aug 22, 2008 at 8:21 AM, Junio C Hamano wrote: > Looks obviously correct. Mind if I forge your sign-off? > Heh, that'll be fine. I don't submit patches that often, so I just forgot - sorry ;-) -Tor Arvid- ``` ## Anand Kumria, 2008-08-25 20:41 Subject: Re: [PATCH] git-p4: Fix one-liner in p4_write_pipe function. Message-ID: URL: https://gitlist.dev/e/g8v5d7%24apj%241%40ger.gmane.org In-Reply-To: <1219353100-1692-1-git-send-email-torarvid@gmail.com> ``` On Thu, 21 Aug 2008 23:11:40 +0200, Tor Arvid Lund wrote: > The function built a p4 command string via the p4_build_cmd function, > but ignored the result. Opps - thanks for catching this. Anand ```