git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-p4: Fix one-liner in p4_write_pipe function.

From
Tor Arvid Lund <torarvid@gmail.com>
Date
Aug 21, 2008, 21:11 UTC
Message-ID
<1219353100-1692-1-git-send-email-torarvid@gmail.com>
The function built a p4 command string via the p4_build_cmd function, but
ignored the result.
---
 contrib/fast-import/git-p4 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index f9865b4..46136d4 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -76,7 +76,7 @@ def write_pipe(c, str):
 
 def p4_write_pipe(c, str):
     real_cmd = p4_build_cmd(c)
-    return write_pipe(c, str)
+    return write_pipe(real_cmd, str)
 
 def read_pipe(c, ignore_error=False):
     if verbose:
-- 
1.6.0.GIT
Next: Junio C Hamano
Message 1 of 4 in “git-p4: Fix one-liner in p4_write_pipe function.”
  1. git-p4: Fix one-liner in p4_write_pipe function.Tor Arvid Lund, Aug 21, 2008
  2. Junio C HamanoAug 22, 2008
  3. Tor Arvid LundAug 22, 2008
  4. Anand KumriaAug 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.