threads / patch / 14679

patchRemove references to git-fetch-pack from "git clone" documentation.

Subject: [PATCH] Remove references to git-fetch-pack from "git clone" documentation.

## tl;dr

4 messages between Jul 25, 2008 and Jul 28, 2008. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Steve Haslam· Jul 25, 2008, 18:37 UTC · lore

"git clone" no longer calls "git-fetch-pack", so the documentation is a bit stale. Instead, state that the -u option is to be used when accessing a repository over ssh.

Signed-off-by: Steve Haslam <shaslam@lastminute.com>
---
This is somewhat related to a patch I just sent; typically I forgot
about the documentation until after sending it.
 Documentation/git-clone.txt |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)
Show changes to Documentation/git-clone.txt +4 −5
diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
index 91efac9..26fd1b1 100644
--- a/Documentation/git-clone.txt
+++ b/Documentation/git-clone.txt
@@ -87,8 +87,8 @@ then the cloned repository will become corrupt.
 
 --quiet::
 -q::
-	Operate quietly.  This flag is passed to "rsync" and
-	'git-fetch-pack' commands when given.
+	Operate quietly.  This flag is also passed to the `rsync'
+	command when given.
 
 --no-checkout::
 -n::
@@ -113,9 +113,8 @@ then the cloned repository will become corrupt.
 
 --upload-pack <upload-pack>::
 -u <upload-pack>::
-	When given, and the repository to clone from is handled
-	by 'git-fetch-pack', `--exec=<upload-pack>` is passed to
-	the command to specify non-default path for the command
+	When given, and the repository to clone from is accessed
+	via ssh, this specifies a non-default path for the command
 	run on the other end.
 
 --template=<template_directory>::

-- 
1.6.0.rc0.43.g1cd6
Johannes Schindelin· Jul 26, 2008, 03:24 UTC · re: Steve Haslam · lore

Re: [PATCH] Remove references to git-fetch-pack from "git clone" documentation.

Hi,
On Fri, 25 Jul 2008, Steve Haslam wrote:
> "git clone" no longer calls "git-fetch-pack",

So it calls it internally, avoiding fork() and exec(). But the code is still git-fetch-pack's. The difference should be lost on the regular Git user.

Ciao, Dscho

Steve Haslam· Jul 28, 2008, 12:32 UTC · re: Johannes Schindelin · lore

Re: [PATCH] Remove references to git-fetch-pack from "git clone" documentation.

Johannes Schindelin wrote:
Show 10 quoted lines
> Hi,
>
> On Fri, 25 Jul 2008, Steve Haslam wrote
>> "git clone" no longer calls "git-fetch-pack",
>>     
>
> So it calls it internally, avoiding fork() and exec().  But the code is 
> still git-fetch-pack's.  The difference should be lost on the regular Git 
> user.
>

Well, I would say that the git-clone command uses code that is also used by the git-fetch-pack command; but as you indicate, this is a minor implementation detail.

I think that the documentation was perhaps too explicit and as a result stale: git-clone certainly does not work any more by creating a "--exec=..." argument to pass to the git-fetch-pack command even internally, it calls code in transport.c. As you say, the difference is immaterial to most users, and a simplified version of the documentation should be adequate (and possibly clearer).

SRH
Johannes Schindelin· Jul 28, 2008, 12:41 UTC · re: Steve Haslam · lore

Re: [PATCH] Remove references to git-fetch-pack from "git clone" documentation.

Hi,
On Mon, 28 Jul 2008, Steve Haslam wrote:
> I think that the documentation was perhaps too explicit and as a result 
> stale: git-clone certainly does not work any more by creating a 
> "--exec=..." argument to pass to the git-fetch-pack command even 
> internally, it calls code in transport.c.
Ah, that is a valid concern which I missed.

Thanks, Dscho

← back to recent threads