Re: [PATCH] Remove references to git-fetch-pack from "git clone" documentation.

From: Steve Haslam <shaslam@lastminute.com>
Date: Jul 28, 2008, 12:32 UTC
Message-ID: <488DBC72.8040204@lastminute.com>
In-Reply-To: <alpine.DEB.1.00.0807260523520.26810@eeepc-johanness>

Johannes Schindelin wrote:

Show 10 quoted lines

> Hi,
>
> On Fri, 25 Jul 2008, Steve Haslam wrote
>> "git clone" no longer calls "git-fetch-pack",
>>     
>
> So it calls it internally, avoiding fork() and exec().  But the code is 
> still git-fetch-pack's.  The difference should be lost on the regular Git 
> user.
>

Well, I would say that the git-clone command uses code that is also used by the git-fetch-pack command; but as you indicate, this is a minor implementation detail.

I think that the documentation was perhaps too explicit and as a result stale: git-clone certainly does not work any more by creating a "--exec=..." argument to pass to the git-fetch-pack command even internally, it calls code in transport.c. As you say, the difference is immaterial to most users, and a simplified version of the documentation should be adequate (and possibly clearer).

SRH