# [PATCH] Remove references to git-fetch-pack from "git clone" documentation. 4 messages from 2008-07-25 to 2008-07-28. Participants: Steve Haslam, Johannes Schindelin. Thread: https://gitlist.dev/t/14679 ## Steve Haslam, 2008-07-25 18:37 Subject: [PATCH] Remove references to git-fetch-pack from "git clone" documentation. Message-ID: <1217011068-1675-1-git-send-email-shaslam@lastminute.com> URL: https://gitlist.dev/e/1217011068-1675-1-git-send-email-shaslam%40lastminute.com ``` "git clone" no longer calls "git-fetch-pack", so the documentation is a bit stale. Instead, state that the -u option is to be used when accessing a repository over ssh. Signed-off-by: Steve Haslam --- This is somewhat related to a patch I just sent; typically I forgot about the documentation until after sending it. Documentation/git-clone.txt | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt index 91efac9..26fd1b1 100644 --- a/Documentation/git-clone.txt +++ b/Documentation/git-clone.txt @@ -87,8 +87,8 @@ then the cloned repository will become corrupt. --quiet:: -q:: - Operate quietly. This flag is passed to "rsync" and - 'git-fetch-pack' commands when given. + Operate quietly. This flag is also passed to the `rsync' + command when given. --no-checkout:: -n:: @@ -113,9 +113,8 @@ then the cloned repository will become corrupt. --upload-pack :: -u :: - When given, and the repository to clone from is handled - by 'git-fetch-pack', `--exec=` is passed to - the command to specify non-default path for the command + When given, and the repository to clone from is accessed + via ssh, this specifies a non-default path for the command run on the other end. --template=:: -- 1.6.0.rc0.43.g1cd6 ``` ## Johannes Schindelin, 2008-07-26 03:24 Subject: Re: [PATCH] Remove references to git-fetch-pack from "git clone" documentation. Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.0807260523520.26810%40eeepc-johanness In-Reply-To: <1217011068-1675-1-git-send-email-shaslam@lastminute.com> ``` Hi, On Fri, 25 Jul 2008, Steve Haslam wrote: > "git clone" no longer calls "git-fetch-pack", So it calls it internally, avoiding fork() and exec(). But the code is still git-fetch-pack's. The difference should be lost on the regular Git user. Ciao, Dscho ``` ## Steve Haslam, 2008-07-28 12:32 Subject: Re: [PATCH] Remove references to git-fetch-pack from "git clone" documentation. Message-ID: <488DBC72.8040204@lastminute.com> URL: https://gitlist.dev/e/488DBC72.8040204%40lastminute.com In-Reply-To: ``` Johannes Schindelin wrote: > Hi, > > On Fri, 25 Jul 2008, Steve Haslam wrote >> "git clone" no longer calls "git-fetch-pack", >> > > So it calls it internally, avoiding fork() and exec(). But the code is > still git-fetch-pack's. The difference should be lost on the regular Git > user. > Well, I would say that the git-clone command uses code that is also used by the git-fetch-pack command; but as you indicate, this is a minor implementation detail. I think that the documentation was perhaps too explicit and as a result stale: git-clone certainly does not work any more by creating a "--exec=..." argument to pass to the git-fetch-pack command even internally, it calls code in transport.c. As you say, the difference is immaterial to most users, and a simplified version of the documentation should be adequate (and possibly clearer). SRH ``` ## Johannes Schindelin, 2008-07-28 12:41 Subject: Re: [PATCH] Remove references to git-fetch-pack from "git clone" documentation. Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.0807281440510.2725%40eeepc-johanness In-Reply-To: <488DBC72.8040204@lastminute.com> ``` Hi, On Mon, 28 Jul 2008, Steve Haslam wrote: > I think that the documentation was perhaps too explicit and as a result > stale: git-clone certainly does not work any more by creating a > "--exec=..." argument to pass to the git-fetch-pack command even > internally, it calls code in transport.c. Ah, that is a valid concern which I missed. Thanks, Dscho ```