{"thread":{"id":"14679","subject":"[PATCH] Remove references to git-fetch-pack from \"git clone\" documentation.","startedAt":"2008-07-25T18:37:48Z","lastAt":"2008-07-28T12:41:16Z","messageCount":4,"participants":["Steve Haslam","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"84918","messageId":"1217011068-1675-1-git-send-email-shaslam@lastminute.com","threadId":"14679","inReplyTo":null,"subject":"[PATCH] Remove references to git-fetch-pack from \"git clone\" documentation.","fromName":"Steve Haslam","fromEmail":"shaslam@lastminute.com","sentAt":"2008-07-25T18:37:48Z","receivedAt":"2008-07-25T18:37:48Z","isPatch":true,"sender":{"key":"shaslam@lastminute.com","avatar":"https://gravatar.com/avatar/df44c553ba2fa56f01414f0c0873212d6f8506f3426586238271bac83fde2edf?d=mp&s=160"},"body":"\"git clone\" no longer calls \"git-fetch-pack\", so the documentation is a bit\nstale. Instead, state that the -u option is to be used when accessing a\nrepository over ssh.\n\nSigned-off-by: Steve Haslam \n---\nThis is somewhat related to a patch I just sent; typically I forgot\nabout the documentation until after sending it.\n\n Documentation/git-clone.txt | 9 ++++-----\n 1 files changed, 4 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt\nindex 91efac9..26fd1b1 100644\n--- a/Documentation/git-clone.txt\n+++ b/Documentation/git-clone.txt\n@@ -87,8 +87,8 @@ then the cloned repository will become corrupt.\n \n --quiet::\n -q::\n-\tOperate quietly. This flag is passed to \"rsync\" and\n-\t'git-fetch-pack' commands when given.\n+\tOperate quietly. This flag is also passed to the `rsync'\n+\tcommand when given.\n \n --no-checkout::\n -n::\n@@ -113,9 +113,8 @@ then the cloned repository will become corrupt.\n \n --upload-pack ::\n -u ::\n-\tWhen given, and the repository to clone from is handled\n-\tby 'git-fetch-pack', `--exec=` is passed to\n-\tthe command to specify non-default path for the command\n+\tWhen given, and the repository to clone from is accessed\n+\tvia ssh, this specifies a non-default path for the command\n \trun on the other end.\n \n --template=::\n-- \n1.6.0.rc0.43.g1cd6\n"},{"id":"84998","messageId":"alpine.DEB.1.00.0807260523520.26810@eeepc-johanness","threadId":"14679","inReplyTo":"1217011068-1675-1-git-send-email-shaslam@lastminute.com","subject":"Re: [PATCH] Remove references to git-fetch-pack from \"git clone\" documentation.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-07-26T03:24:48Z","receivedAt":"2008-07-26T03:24:48Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 25 Jul 2008, Steve Haslam wrote:\n\n> \"git clone\" no longer calls \"git-fetch-pack\",\n\nSo it calls it internally, avoiding fork() and exec(). But the code is \nstill git-fetch-pack's. The difference should be lost on the regular Git \nuser.\n\nCiao,\nDscho\n"},{"id":"85284","messageId":"488DBC72.8040204@lastminute.com","threadId":"14679","inReplyTo":"alpine.DEB.1.00.0807260523520.26810@eeepc-johanness","subject":"Re: [PATCH] Remove references to git-fetch-pack from \"git clone\" documentation.","fromName":"Steve Haslam","fromEmail":"shaslam@lastminute.com","sentAt":"2008-07-28T12:32:50Z","receivedAt":"2008-07-28T12:32:50Z","isPatch":true,"sender":{"key":"shaslam@lastminute.com","avatar":"https://gravatar.com/avatar/df44c553ba2fa56f01414f0c0873212d6f8506f3426586238271bac83fde2edf?d=mp&s=160"},"body":"Johannes Schindelin wrote:\n> Hi,\n>\n> On Fri, 25 Jul 2008, Steve Haslam wrote\n>> \"git clone\" no longer calls \"git-fetch-pack\",\n>> \n>\n> So it calls it internally, avoiding fork() and exec(). But the code is \n> still git-fetch-pack's. The difference should be lost on the regular Git \n> user.\n> \nWell, I would say that the git-clone command uses code that is also used \nby the git-fetch-pack command; but as you indicate, this is a minor \nimplementation detail.\n\nI think that the documentation was perhaps too explicit and as a result \nstale: git-clone certainly does not work any more by creating a \n\"--exec=...\" argument to pass to the git-fetch-pack command even \ninternally, it calls code in transport.c. As you say, the difference is \nimmaterial to most users, and a simplified version of the documentation \nshould be adequate (and possibly clearer).\n\nSRH\n"},{"id":"85286","messageId":"alpine.DEB.1.00.0807281440510.2725@eeepc-johanness","threadId":"14679","inReplyTo":"488DBC72.8040204@lastminute.com","subject":"Re: [PATCH] Remove references to git-fetch-pack from \"git clone\" documentation.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-07-28T12:41:16Z","receivedAt":"2008-07-28T12:41:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 28 Jul 2008, Steve Haslam wrote:\n\n> I think that the documentation was perhaps too explicit and as a result \n> stale: git-clone certainly does not work any more by creating a \n> \"--exec=...\" argument to pass to the git-fetch-pack command even \n> internally, it calls code in transport.c.\n\nAh, that is a valid concern which I missed.\n\nThanks,\nDscho\n"}]}