threads / patch / 14224

patchDon't cut off last character of commit descriptions.

Subject: [PATCH] Don't cut off last character of commit descriptions.

## tl;dr

3 messages between Jun 30, 2008 and Jul 16, 2008. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Nikolaj Schumacher· Jun 30, 2008, 10:08 UTC · lore

>From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001

From: Nikolaj Schumacher <git@nschum.de>
Date: Mon, 30 Jun 2008 12:06:01 +0200
Subject: [PATCH] Don't cut off last character of commit descriptions.

---
 contrib/emacs/git-blame.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to contrib/emacs/git-blame.el +1 −1

diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
index 9f92cd2..4fa70c5 100644
--- a/contrib/emacs/git-blame.el
+++ b/contrib/emacs/git-blame.el
@@ -381,7 +381,7 @@ See also function `git-blame-mode'."
                   "log" "-1"
 		  (concat "--pretty=" git-blame-log-oneline-format)
                   hash)
-    (buffer-substring (point-min) (1- (point-max)))))
+    (buffer-substring (point-min) (point-max))))
 
 (defvar git-blame-last-identification nil)
 (make-variable-buffer-local 'git-blame-last-identification)

-- 
1.5.5.3

David Kågedal· Jun 30, 2008, 10:55 UTC · re: Nikolaj Schumacher · lore

Re: [PATCH] Don't cut off last character of commit descriptions.

Nikolaj Schumacher <n_schumacher@web.de> writes:

Show 22 quoted lines

> From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001
> From: Nikolaj Schumacher <git@nschum.de>
> Date: Mon, 30 Jun 2008 12:06:01 +0200
> Subject: [PATCH] Don't cut off last character of commit descriptions.
>
> ---
>  contrib/emacs/git-blame.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
> index 9f92cd2..4fa70c5 100644
> --- a/contrib/emacs/git-blame.el
> +++ b/contrib/emacs/git-blame.el
> @@ -381,7 +381,7 @@ See also function `git-blame-mode'."
>                    "log" "-1"
>  		  (concat "--pretty=" git-blame-log-oneline-format)
>                    hash)
> -    (buffer-substring (point-min) (1- (point-max)))))
> +    (buffer-substring (point-min) (point-max))))
>  
>  (defvar git-blame-last-identification nil)
>  (make-variable-buffer-local 'git-blame-last-identification)

Yes, this should have been part of 24a2293ad35d567530048f0d2b0d11e0012af26d git-blame.el: show the when, who and what in the minibuffer. that changed from using --pretty=oneline to --pretty=format:... without terminating newline.

-- 
David Kågedal

Junio C Hamano· Jul 16, 2008, 21:11 UTC · re: David Kågedal · lore

Re: [PATCH] Don't cut off last character of commit descriptions.

David Kågedal <davidk@lysator.liu.se> writes:

Show 29 quoted lines

> Nikolaj Schumacher <n_schumacher@web.de> writes:
>
>> From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001
>> From: Nikolaj Schumacher <git@nschum.de>
>> Date: Mon, 30 Jun 2008 12:06:01 +0200
>> Subject: [PATCH] Don't cut off last character of commit descriptions.
>>
>> ---
>>  contrib/emacs/git-blame.el |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
>> index 9f92cd2..4fa70c5 100644
>> --- a/contrib/emacs/git-blame.el
>> +++ b/contrib/emacs/git-blame.el
>> @@ -381,7 +381,7 @@ See also function `git-blame-mode'."
>>                    "log" "-1"
>>  		  (concat "--pretty=" git-blame-log-oneline-format)
>>                    hash)
>> -    (buffer-substring (point-min) (1- (point-max)))))
>> +    (buffer-substring (point-min) (point-max))))
>>  
>>  (defvar git-blame-last-identification nil)
>>  (make-variable-buffer-local 'git-blame-last-identification)
>
> Yes, this should have been part of
> 24a2293ad35d567530048f0d2b0d11e0012af26d git-blame.el: show the when,
> who and what in the minibuffer. that changed from using
> --pretty=oneline to --pretty=format:... without terminating newline.

Sorry, I realize I haven't applied the patch from Nikolaj. Should I take this as an Ack?