git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Don't cut off last character of commit descriptions.

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 16, 2008, 21:11 UTC
Message-ID
<7viqv5pm9e.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<87k5g7fb05.fsf@lysator.liu.se>
David Kågedal <davidk@lysator.liu.se> writes:
Show 29 quoted lines
> Nikolaj Schumacher <n_schumacher@web.de> writes:
>
>> From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001
>> From: Nikolaj Schumacher <git@nschum.de>
>> Date: Mon, 30 Jun 2008 12:06:01 +0200
>> Subject: [PATCH] Don't cut off last character of commit descriptions.
>>
>> ---
>>  contrib/emacs/git-blame.el |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
>> index 9f92cd2..4fa70c5 100644
>> --- a/contrib/emacs/git-blame.el
>> +++ b/contrib/emacs/git-blame.el
>> @@ -381,7 +381,7 @@ See also function `git-blame-mode'."
>>                    "log" "-1"
>>  		  (concat "--pretty=" git-blame-log-oneline-format)
>>                    hash)
>> -    (buffer-substring (point-min) (1- (point-max)))))
>> +    (buffer-substring (point-min) (point-max))))
>>  
>>  (defvar git-blame-last-identification nil)
>>  (make-variable-buffer-local 'git-blame-last-identification)
>
> Yes, this should have been part of
> 24a2293ad35d567530048f0d2b0d11e0012af26d git-blame.el: show the when,
> who and what in the minibuffer. that changed from using
> --pretty=oneline to --pretty=format:... without terminating newline.

Sorry, I realize I haven't applied the patch from Nikolaj. Should I take this as an Ack?

Previous: David Kågedal
Message 3 of 3 in “Don't cut off last character of commit descriptions.”
  1. Don't cut off last character of commit descriptions.Nikolaj Schumacher, Jun 30, 2008
  2. David KågedalJun 30, 2008
  3. Junio C HamanoJul 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.