# [PATCH] Don't cut off last character of commit descriptions. 3 messages from 2008-06-30 to 2008-07-16. Participants: Nikolaj Schumacher, David Kågedal, Junio C Hamano. Thread: https://gitlist.dev/t/14224 ## Nikolaj Schumacher, 2008-06-30 10:08 Subject: [PATCH] Don't cut off last character of commit descriptions. Message-ID: URL: https://gitlist.dev/e/m2abh3z14f.fsf%40nschum.de ``` >From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001 From: Nikolaj Schumacher Date: Mon, 30 Jun 2008 12:06:01 +0200 Subject: [PATCH] Don't cut off last character of commit descriptions. --- contrib/emacs/git-blame.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el index 9f92cd2..4fa70c5 100644 --- a/contrib/emacs/git-blame.el +++ b/contrib/emacs/git-blame.el @@ -381,7 +381,7 @@ See also function `git-blame-mode'." "log" "-1" (concat "--pretty=" git-blame-log-oneline-format) hash) - (buffer-substring (point-min) (1- (point-max))))) + (buffer-substring (point-min) (point-max)))) (defvar git-blame-last-identification nil) (make-variable-buffer-local 'git-blame-last-identification) -- 1.5.5.3 ``` ## David Kågedal, 2008-06-30 10:55 Subject: Re: [PATCH] Don't cut off last character of commit descriptions. Message-ID: <87k5g7fb05.fsf@lysator.liu.se> URL: https://gitlist.dev/e/87k5g7fb05.fsf%40lysator.liu.se In-Reply-To: ``` Nikolaj Schumacher writes: > From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001 > From: Nikolaj Schumacher > Date: Mon, 30 Jun 2008 12:06:01 +0200 > Subject: [PATCH] Don't cut off last character of commit descriptions. > > --- > contrib/emacs/git-blame.el | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el > index 9f92cd2..4fa70c5 100644 > --- a/contrib/emacs/git-blame.el > +++ b/contrib/emacs/git-blame.el > @@ -381,7 +381,7 @@ See also function `git-blame-mode'." > "log" "-1" > (concat "--pretty=" git-blame-log-oneline-format) > hash) > - (buffer-substring (point-min) (1- (point-max))))) > + (buffer-substring (point-min) (point-max)))) > > (defvar git-blame-last-identification nil) > (make-variable-buffer-local 'git-blame-last-identification) Yes, this should have been part of 24a2293ad35d567530048f0d2b0d11e0012af26d git-blame.el: show the when, who and what in the minibuffer. that changed from using --pretty=oneline to --pretty=format:... without terminating newline. -- David Kågedal ``` ## Junio C Hamano, 2008-07-16 21:11 Subject: Re: [PATCH] Don't cut off last character of commit descriptions. Message-ID: <7viqv5pm9e.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7viqv5pm9e.fsf%40gitster.siamese.dyndns.org In-Reply-To: <87k5g7fb05.fsf@lysator.liu.se> ``` David Kågedal writes: > Nikolaj Schumacher writes: > >> From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001 >> From: Nikolaj Schumacher >> Date: Mon, 30 Jun 2008 12:06:01 +0200 >> Subject: [PATCH] Don't cut off last character of commit descriptions. >> >> --- >> contrib/emacs/git-blame.el | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el >> index 9f92cd2..4fa70c5 100644 >> --- a/contrib/emacs/git-blame.el >> +++ b/contrib/emacs/git-blame.el >> @@ -381,7 +381,7 @@ See also function `git-blame-mode'." >> "log" "-1" >> (concat "--pretty=" git-blame-log-oneline-format) >> hash) >> - (buffer-substring (point-min) (1- (point-max))))) >> + (buffer-substring (point-min) (point-max)))) >> >> (defvar git-blame-last-identification nil) >> (make-variable-buffer-local 'git-blame-last-identification) > > Yes, this should have been part of > 24a2293ad35d567530048f0d2b0d11e0012af26d git-blame.el: show the when, > who and what in the minibuffer. that changed from using > --pretty=oneline to --pretty=format:... without terminating newline. Sorry, I realize I haven't applied the patch from Nikolaj. Should I take this as an Ack? ```