{"thread":{"id":"14224","subject":"[PATCH] Don't cut off last character of commit descriptions.","startedAt":"2008-06-30T10:08:16Z","lastAt":"2008-07-16T21:11:41Z","messageCount":3,"participants":["Nikolaj Schumacher","David Kågedal","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"81737","messageId":"m2abh3z14f.fsf@nschum.de","threadId":"14224","inReplyTo":null,"subject":"[PATCH] Don't cut off last character of commit descriptions.","fromName":"Nikolaj Schumacher","fromEmail":"n_schumacher@web.de","sentAt":"2008-06-30T10:08:16Z","receivedAt":"2008-06-30T10:08:16Z","isPatch":true,"sender":{"key":"n_schumacher@web.de","avatar":null},"body":">From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001\nFrom: Nikolaj Schumacher <git@nschum.de>\nDate: Mon, 30 Jun 2008 12:06:01 +0200\nSubject: [PATCH] Don't cut off last character of commit descriptions.\n\n---\n contrib/emacs/git-blame.el |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el\nindex 9f92cd2..4fa70c5 100644\n--- a/contrib/emacs/git-blame.el\n+++ b/contrib/emacs/git-blame.el\n@@ -381,7 +381,7 @@ See also function `git-blame-mode'.\"\n                   \"log\" \"-1\"\n \t\t  (concat \"--pretty=\" git-blame-log-oneline-format)\n                   hash)\n-    (buffer-substring (point-min) (1- (point-max)))))\n+    (buffer-substring (point-min) (point-max))))\n \n (defvar git-blame-last-identification nil)\n (make-variable-buffer-local 'git-blame-last-identification)\n-- \n1.5.5.3\n"},{"id":"81741","messageId":"87k5g7fb05.fsf@lysator.liu.se","threadId":"14224","inReplyTo":"m2abh3z14f.fsf@nschum.de","subject":"Re: [PATCH] Don't cut off last character of commit descriptions.","fromName":"David Kågedal","fromEmail":"davidk@lysator.liu.se","sentAt":"2008-06-30T10:55:06Z","receivedAt":"2008-06-30T10:55:06Z","isPatch":true,"sender":{"key":"davidk@lysator.liu.se","avatar":"https://avatars.githubusercontent.com/u/60530?v=4"},"body":"Nikolaj Schumacher <n_schumacher@web.de> writes:\n\n> From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001\n> From: Nikolaj Schumacher <git@nschum.de>\n> Date: Mon, 30 Jun 2008 12:06:01 +0200\n> Subject: [PATCH] Don't cut off last character of commit descriptions.\n>\n> ---\n>  contrib/emacs/git-blame.el |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el\n> index 9f92cd2..4fa70c5 100644\n> --- a/contrib/emacs/git-blame.el\n> +++ b/contrib/emacs/git-blame.el\n> @@ -381,7 +381,7 @@ See also function `git-blame-mode'.\"\n>                    \"log\" \"-1\"\n>  \t\t  (concat \"--pretty=\" git-blame-log-oneline-format)\n>                    hash)\n> -    (buffer-substring (point-min) (1- (point-max)))))\n> +    (buffer-substring (point-min) (point-max))))\n>  \n>  (defvar git-blame-last-identification nil)\n>  (make-variable-buffer-local 'git-blame-last-identification)\n\nYes, this should have been part of\n24a2293ad35d567530048f0d2b0d11e0012af26d git-blame.el: show the when,\nwho and what in the minibuffer. that changed from using\n--pretty=oneline to --pretty=format:... without terminating newline.\n\n-- \nDavid Kågedal\n"},{"id":"83595","messageId":"7viqv5pm9e.fsf@gitster.siamese.dyndns.org","threadId":"14224","inReplyTo":"87k5g7fb05.fsf@lysator.liu.se","subject":"Re: [PATCH] Don't cut off last character of commit descriptions.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-07-16T21:11:41Z","receivedAt":"2008-07-16T21:11:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"David Kågedal <davidk@lysator.liu.se> writes:\n\n> Nikolaj Schumacher <n_schumacher@web.de> writes:\n>\n>> From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001\n>> From: Nikolaj Schumacher <git@nschum.de>\n>> Date: Mon, 30 Jun 2008 12:06:01 +0200\n>> Subject: [PATCH] Don't cut off last character of commit descriptions.\n>>\n>> ---\n>>  contrib/emacs/git-blame.el |    2 +-\n>>  1 files changed, 1 insertions(+), 1 deletions(-)\n>>\n>> diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el\n>> index 9f92cd2..4fa70c5 100644\n>> --- a/contrib/emacs/git-blame.el\n>> +++ b/contrib/emacs/git-blame.el\n>> @@ -381,7 +381,7 @@ See also function `git-blame-mode'.\"\n>>                    \"log\" \"-1\"\n>>  \t\t  (concat \"--pretty=\" git-blame-log-oneline-format)\n>>                    hash)\n>> -    (buffer-substring (point-min) (1- (point-max)))))\n>> +    (buffer-substring (point-min) (point-max))))\n>>  \n>>  (defvar git-blame-last-identification nil)\n>>  (make-variable-buffer-local 'git-blame-last-identification)\n>\n> Yes, this should have been part of\n> 24a2293ad35d567530048f0d2b0d11e0012af26d git-blame.el: show the when,\n> who and what in the minibuffer. that changed from using\n> --pretty=oneline to --pretty=format:... without terminating newline.\n\nSorry, I realize I haven't applied the patch from Nikolaj.  Should I take\nthis as an Ack?\n"}]}