threads / patch / 12439

patchgit-submodule: Fix typo 'url' which should be '$url'

Subject: [PATCH] git-submodule: Fix typo 'url' which should be '$url'

## tl;dr

2 messages between Mar 3, 2008 and Mar 3, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ping Yin· Mar 3, 2008, 02:03 UTC · lore

Fix typo in 'test -z "url"' when checking whether a submodule url is empty. "url" should be "$url".

More thinking, why does empty url mean uninitialized? How about the case that the submodule url is deleted from .git/config?

Signed-off-by: Ping Yin <pkufranky@gmail.com>
---
 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to git-submodule.sh +1 −1

diff --git a/git-submodule.sh b/git-submodule.sh
index a6aaf40..67d3224 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -362,7 +362,7 @@ cmd_status()
 	do
 		name=$(module_name "$path") || exit
 		url=$(git config submodule."$name".url)
-		if test -z "url" || ! test -d "$path"/.git
+		if test -z "$url" || ! test -d "$path"/.git
 		then
 			say "-$sha1 $path"
 			continue;

-- 
1.5.4.3.347.g5314c

Junio C Hamano· Mar 3, 2008, 02:19 UTC · re: Ping Yin · lore

Re: [PATCH] git-submodule: Fix typo 'url' which should be '$url'

Ping Yin <pkufranky@gmail.com> writes:

> More thinking, why does empty url mean uninitialized? How about the
> case that the submodule url is deleted from .git/config?

That means the user is not interested in that subproject.

In-tree .gitmodules is merely a place a user who is interested in a partcular module described in it will pick up a _hint_ about attributes (currently, URL but there may be others) on the module from, when showing and recording his interest.

Notice I said "hint"; .gitmodules is _not_ meant as "default" in the sense that "if the user does not have it in .git/config then read from it".

"Is it checked-out", would be a good indication of user's interest when you talk about the current status (like "git submodule summary"), but if you think about the case of switching between branches that has and does not have a module, you would realize that "is it checked-out?" cannot be the authoritative and only place to record the user's interest.