{"thread":{"id":"12439","subject":"[PATCH] git-submodule: Fix typo 'url' which should be '$url'","startedAt":"2008-03-03T02:03:18Z","lastAt":"2008-03-03T02:19:37Z","messageCount":2,"participants":["Ping Yin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"70721","messageId":"1204509798-671-1-git-send-email-pkufranky@gmail.com","threadId":"12439","inReplyTo":null,"subject":"[PATCH] git-submodule: Fix typo 'url' which should be '$url'","fromName":"Ping Yin","fromEmail":"pkufranky@gmail.com","sentAt":"2008-03-03T02:03:18Z","receivedAt":"2008-03-03T02:03:18Z","isPatch":true,"sender":{"key":"pkufranky@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5346?v=4"},"body":"Fix typo in 'test -z \"url\"' when checking whether a submodule url is\nempty. \"url\" should be \"$url\".\n\nMore thinking, why does empty url mean uninitialized? How about the\ncase that the submodule url is deleted from .git/config?\n\nSigned-off-by: Ping Yin <pkufranky@gmail.com>\n---\n git-submodule.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-submodule.sh b/git-submodule.sh\nindex a6aaf40..67d3224 100755\n--- a/git-submodule.sh\n+++ b/git-submodule.sh\n@@ -362,7 +362,7 @@ cmd_status()\n \tdo\n \t\tname=$(module_name \"$path\") || exit\n \t\turl=$(git config submodule.\"$name\".url)\n-\t\tif test -z \"url\" || ! test -d \"$path\"/.git\n+\t\tif test -z \"$url\" || ! test -d \"$path\"/.git\n \t\tthen\n \t\t\tsay \"-$sha1 $path\"\n \t\t\tcontinue;\n-- \n1.5.4.3.347.g5314c\n\n"},{"id":"70724","messageId":"7vy790k0qu.fsf@gitster.siamese.dyndns.org","threadId":"12439","inReplyTo":"1204509798-671-1-git-send-email-pkufranky@gmail.com","subject":"Re: [PATCH] git-submodule: Fix typo 'url' which should be '$url'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-03-03T02:19:37Z","receivedAt":"2008-03-03T02:19:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ping Yin <pkufranky@gmail.com> writes:\n\n> More thinking, why does empty url mean uninitialized? How about the\n> case that the submodule url is deleted from .git/config?\n\nThat means the user is not interested in that subproject.\n\nIn-tree .gitmodules is merely a place a user who is interested in a\npartcular module described in it will pick up a _hint_ about attributes\n(currently, URL but there may be others) on the module from, when showing\nand recording his interest.\n\nNotice I said \"hint\"; .gitmodules is _not_ meant as \"default\" in the sense\nthat \"if the user does not have it in .git/config then read from it\".\n\n\"Is it checked-out\", would be a good indication of user's interest when\nyou talk about the current status (like \"git submodule summary\"), but if\nyou think about the case of switching between branches that has and does\nnot have a module, you would realize that \"is it checked-out?\" cannot be\nthe authoritative and only place to record the user's interest.\n"}]}