# [PATCH] git-submodule: Fix typo 'url' which should be '$url'

2 messages from 2008-03-03 to 2008-03-03. Participants: Ping Yin, Junio C Hamano.
Thread: https://gitlist.dev/t/12439

## Ping Yin, 2008-03-03 02:03

Subject: [PATCH] git-submodule: Fix typo 'url' which should be '$url'
Message-ID: <1204509798-671-1-git-send-email-pkufranky@gmail.com>
URL: https://gitlist.dev/e/1204509798-671-1-git-send-email-pkufranky%40gmail.com

```
Fix typo in 'test -z "url"' when checking whether a submodule url is
empty. "url" should be "$url".

More thinking, why does empty url mean uninitialized? How about the
case that the submodule url is deleted from .git/config?

Signed-off-by: Ping Yin <pkufranky@gmail.com>
---
 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-submodule.sh b/git-submodule.sh
index a6aaf40..67d3224 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -362,7 +362,7 @@ cmd_status()
 	do
 		name=$(module_name "$path") || exit
 		url=$(git config submodule."$name".url)
-		if test -z "url" || ! test -d "$path"/.git
+		if test -z "$url" || ! test -d "$path"/.git
 		then
 			say "-$sha1 $path"
 			continue;
-- 
1.5.4.3.347.g5314c


```

## Junio C Hamano, 2008-03-03 02:19

Subject: Re: [PATCH] git-submodule: Fix typo 'url' which should be '$url'
Message-ID: <7vy790k0qu.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vy790k0qu.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <1204509798-671-1-git-send-email-pkufranky@gmail.com>

```
Ping Yin <pkufranky@gmail.com> writes:

> More thinking, why does empty url mean uninitialized? How about the
> case that the submodule url is deleted from .git/config?

That means the user is not interested in that subproject.

In-tree .gitmodules is merely a place a user who is interested in a
partcular module described in it will pick up a _hint_ about attributes
(currently, URL but there may be others) on the module from, when showing
and recording his interest.

Notice I said "hint"; .gitmodules is _not_ meant as "default" in the sense
that "if the user does not have it in .git/config then read from it".

"Is it checked-out", would be a good indication of user's interest when
you talk about the current status (like "git submodule summary"), but if
you think about the case of switching between branches that has and does
not have a module, you would realize that "is it checked-out?" cannot be
the authoritative and only place to record the user's interest.

```