git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-submodule: Fix typo 'url' which should be '$url'

From
Ping Yin <pkufranky@gmail.com>
Date
Mar 3, 2008, 02:03 UTC
Message-ID
<1204509798-671-1-git-send-email-pkufranky@gmail.com>

Fix typo in 'test -z "url"' when checking whether a submodule url is empty. "url" should be "$url".

More thinking, why does empty url mean uninitialized? How about the case that the submodule url is deleted from .git/config?

Signed-off-by: Ping Yin <pkufranky@gmail.com>
---
 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index a6aaf40..67d3224 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -362,7 +362,7 @@ cmd_status()
 	do
 		name=$(module_name "$path") || exit
 		url=$(git config submodule."$name".url)
-		if test -z "url" || ! test -d "$path"/.git
+		if test -z "$url" || ! test -d "$path"/.git
 		then
 			say "-$sha1 $path"
 			continue;
-- 
1.5.4.3.347.g5314c
Next: Junio C Hamano
Message 1 of 2 in “git-submodule: Fix typo 'url' which should be '$url'”
  1. git-submodule: Fix typo 'url' which should be '$url'Ping Yin, Mar 3, 2008
  2. Junio C HamanoMar 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.