Gerrit PapeAfter changing builtin-tag.c to use strbuf in fd17f5b (Replace all read_fd use with strbuf_read, and get rid of it.), the last condition in do_sign() will always be false, as it's checked already right above. So let's remove the cruft.
Signed-off-by: Gerrit Pape <pape@smarden.org> --- builtin-tag.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
Show changes to builtin-tag.c +0 −3
diff --git a/builtin-tag.c b/builtin-tag.c index 4a4a88c..716b4ff 100644 --- a/builtin-tag.c +++ b/builtin-tag.c @@ -236,9 +236,6 @@ static int do_sign(struct strbuf *buffer) if (finish_command(&gpg) || !len || len < 0) return error("gpg failed to sign the tag"); - if (len < 0) - return error("could not read the entire signature from gpg."); - return 0; }
-- 1.5.4.2