git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] builtin-tag.c: remove cruft

From
Gerrit Pape <pape@smarden.org>
Date
Feb 22, 2008, 09:53 UTC
Message-ID
<20080222095309.32720.qmail@1e4c13667103ad.315fe32.mid.smarden.org>

After changing builtin-tag.c to use strbuf in fd17f5b (Replace all read_fd use with strbuf_read, and get rid of it.), the last condition in do_sign() will always be false, as it's checked already right above. So let's remove the cruft.

Signed-off-by: Gerrit Pape <pape@smarden.org>
---
 builtin-tag.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/builtin-tag.c b/builtin-tag.c
index 4a4a88c..716b4ff 100644
--- a/builtin-tag.c
+++ b/builtin-tag.c
@@ -236,9 +236,6 @@ static int do_sign(struct strbuf *buffer)
 	if (finish_command(&gpg) || !len || len < 0)
 		return error("gpg failed to sign the tag");
 
-	if (len < 0)
-		return error("could not read the entire signature from gpg.");
-
 	return 0;
 }
 
-- 
1.5.4.2
Message 1 of 1 in “builtin-tag.c: remove cruft”
  1. builtin-tag.c: remove cruftGerrit Pape, Feb 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.