{"thread":{"id":"12257","subject":"[PATCH] builtin-tag.c: remove cruft","startedAt":"2008-02-22T09:53:09Z","lastAt":"2008-02-22T09:53:09Z","messageCount":1,"participants":["Gerrit Pape"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"69568","messageId":"20080222095309.32720.qmail@1e4c13667103ad.315fe32.mid.smarden.org","threadId":"12257","inReplyTo":null,"subject":"[PATCH] builtin-tag.c: remove cruft","fromName":"Gerrit Pape","fromEmail":"pape@smarden.org","sentAt":"2008-02-22T09:53:09Z","receivedAt":"2008-02-22T09:53:09Z","isPatch":true,"sender":{"key":"pape@smarden.org","avatar":"https://avatars.githubusercontent.com/u/143170252?v=4"},"body":"After changing builtin-tag.c to use strbuf in fd17f5b (Replace all\nread_fd use with strbuf_read, and get rid of it.), the last condition\nin do_sign() will always be false, as it's checked already right\nabove.  So let's remove the cruft.\n\nSigned-off-by: Gerrit Pape <pape@smarden.org>\n---\n builtin-tag.c |    3 ---\n 1 files changed, 0 insertions(+), 3 deletions(-)\n\ndiff --git a/builtin-tag.c b/builtin-tag.c\nindex 4a4a88c..716b4ff 100644\n--- a/builtin-tag.c\n+++ b/builtin-tag.c\n@@ -236,9 +236,6 @@ static int do_sign(struct strbuf *buffer)\n \tif (finish_command(&gpg) || !len || len < 0)\n \t\treturn error(\"gpg failed to sign the tag\");\n \n-\tif (len < 0)\n-\t\treturn error(\"could not read the entire signature from gpg.\");\n-\n \treturn 0;\n }\n \n-- \n1.5.4.2\n"}]}