# [PATCH] builtin-tag.c: remove cruft

1 messages from 2008-02-22 to 2008-02-22. Participants: Gerrit Pape.
Thread: https://gitlist.dev/t/12257

## Gerrit Pape, 2008-02-22 09:53

Subject: [PATCH] builtin-tag.c: remove cruft
Message-ID: <20080222095309.32720.qmail@1e4c13667103ad.315fe32.mid.smarden.org>
URL: https://gitlist.dev/e/20080222095309.32720.qmail%401e4c13667103ad.315fe32.mid.smarden.org

```
After changing builtin-tag.c to use strbuf in fd17f5b (Replace all
read_fd use with strbuf_read, and get rid of it.), the last condition
in do_sign() will always be false, as it's checked already right
above.  So let's remove the cruft.

Signed-off-by: Gerrit Pape <pape@smarden.org>
---
 builtin-tag.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/builtin-tag.c b/builtin-tag.c
index 4a4a88c..716b4ff 100644
--- a/builtin-tag.c
+++ b/builtin-tag.c
@@ -236,9 +236,6 @@ static int do_sign(struct strbuf *buffer)
 	if (finish_command(&gpg) || !len || len < 0)
 		return error("gpg failed to sign the tag");
 
-	if (len < 0)
-		return error("could not read the entire signature from gpg.");
-
 	return 0;
 }
 
-- 
1.5.4.2

```