threads / rfc / 11851

RFC patchgitweb: Make feed entries point to commitdiff view

Subject: [PATCH/RFC] gitweb: Make feed entries point to commitdiff view

## tl;dr

3 messages between Feb 3, 2008 and Feb 6, 2008. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Jakub Narebski· Feb 3, 2008, 11:38 UTC · lore
From: Florian La Roche <laroche@redhat.com>

Change feeds entries (feeds items) from pointing (linking) to 'commit' view to pointing to 'commitdiff' view.

First, feed entries have whatchanged-like list of files which were modified in a commit, so 'commitdiff' view more naturally reflects feed entry (in more naturally alternate / extended version of a feed item). Second, this way the patches are shown directly and code review is done more easily via watching feeds.

[jn: Rewritten commit message]
Signed-off-by: Florian La Roche <laroche@redhat.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This patch was originally send by Florian La Roche in
  "[PATCH] gitweb: Change feeds from commit to commitdiff output"
  Message-ID: <20080110130900.GA9395%40dudweiler.stuttgart.redhat.com>
  http://thread.gmane.org/gmane.comp.version-control.git/70068

As requested, Junio, I have marged this patch as an RFC, although I think that with the improved commit message the reason for this change is more obvious, and it is a go.

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to gitweb/gitweb.perl +1 −1
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index ae2d057..8ef2735 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -5565,7 +5565,7 @@ XML
 			or next;
 
 		# print element (entry, item)
-		my $co_url = href(-full=>1, action=>"commit", hash=>$commit);
+		my $co_url = href(-full=>1, action=>"commitdiff", hash=>$commit);
 		if ($format eq 'rss') {
 			print "<item>\n" .
 			      "<title>" . esc_html($co{'title'}) . "</title>\n" .
-- 
1.5.4
Junio C Hamano· Feb 6, 2008, 20:46 UTC · re: Jakub Narebski · lore

Re: [PATCH/RFC] gitweb: Make feed entries point to commitdiff view

Jakub Narebski <jnareb@gmail.com> writes:
> I think that with the improved commit message the reason for this
> change is more obvious, and it is a go.
Thanks.  Looks good.
Jakub Narebski· Feb 6, 2008, 21:22 UTC · re: Junio C Hamano · lore

Re: [PATCH/RFC] gitweb: Make feed entries point to commitdiff view

Dnia środa 6. lutego 2008 21:46, Junio C Hamano napisał:
Show 6 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes:
> 
> > I think that with the improved commit message the reason for this
> > change is more obvious, and it is a go.
> 
> Thanks.  Looks good.
Errr... in the commit message
Show 5 quoted lines
>> First, feed entries have whatchanged-like list of files which were
>> modified in a commit, so 'commitdiff' view more naturally reflects
>> feed entry (in more naturally alternate / extended version of a feed
>> item). Second, this way the patches are shown directly and code review
>> is done more easily via watching feeds.
"... (in more naturally ..." should be "... (is more naturally ...".

Unfortunately this kind of errors are hard to catch (and spellchecker would not help any)

-- 
Jakub Narebski
Poland

← back to recent threads