{"thread":{"id":"11851","subject":"[PATCH/RFC] gitweb: Make feed entries point to commitdiff view","startedAt":"2008-02-03T11:38:46Z","lastAt":"2008-02-06T21:22:37Z","messageCount":3,"participants":["Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"67209","messageId":"1202038726-4221-1-git-send-email-jnareb@gmail.com","threadId":"11851","inReplyTo":null,"subject":"[PATCH/RFC] gitweb: Make feed entries point to commitdiff view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-02-03T11:38:46Z","receivedAt":"2008-02-03T11:38:46Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"From: Florian La Roche <laroche@redhat.com>\n\nChange feeds entries (feeds items) from pointing (linking) to 'commit'\nview to pointing to 'commitdiff' view.\n\nFirst, feed entries have whatchanged-like list of files which were\nmodified in a commit, so 'commitdiff' view more naturally reflects\nfeed entry (in more naturally alternate / extended version of a feed\nitem). Second, this way the patches are shown directly and code review\nis done more easily via watching feeds.\n\n[jn: Rewritten commit message]\n\nSigned-off-by: Florian La Roche <laroche@redhat.com>\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nThis patch was originally send by Florian La Roche in\n  \"[PATCH] gitweb: Change feeds from commit to commitdiff output\"\n\n  Message-ID: <20080110130900.GA9395%40dudweiler.stuttgart.redhat.com>\n  http://thread.gmane.org/gmane.comp.version-control.git/70068\n\nAs requested, Junio, I have marged this patch as an RFC, although\nI think that with the improved commit message the reason for this\nchange is more obvious, and it is a go.\n\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex ae2d057..8ef2735 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -5565,7 +5565,7 @@ XML\n \t\t\tor next;\n \n \t\t# print element (entry, item)\n-\t\tmy $co_url = href(-full=>1, action=>\"commit\", hash=>$commit);\n+\t\tmy $co_url = href(-full=>1, action=>\"commitdiff\", hash=>$commit);\n \t\tif ($format eq 'rss') {\n \t\t\tprint \"<item>\\n\" .\n \t\t\t      \"<title>\" . esc_html($co{'title'}) . \"</title>\\n\" .\n-- \n1.5.4\n"},{"id":"67708","messageId":"7vd4r9vmnd.fsf@gitster.siamese.dyndns.org","threadId":"11851","inReplyTo":"1202038726-4221-1-git-send-email-jnareb@gmail.com","subject":"Re: [PATCH/RFC] gitweb: Make feed entries point to commitdiff view","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-06T20:46:14Z","receivedAt":"2008-02-06T20:46:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> I think that with the improved commit message the reason for this\n> change is more obvious, and it is a go.\n\nThanks.  Looks good.\n"},{"id":"67714","messageId":"200802062222.38691.jnareb@gmail.com","threadId":"11851","inReplyTo":"7vd4r9vmnd.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH/RFC] gitweb: Make feed entries point to commitdiff view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-02-06T21:22:37Z","receivedAt":"2008-02-06T21:22:37Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Dnia środa 6. lutego 2008 21:46, Junio C Hamano napisał:\n> Jakub Narebski <jnareb@gmail.com> writes:\n> \n> > I think that with the improved commit message the reason for this\n> > change is more obvious, and it is a go.\n> \n> Thanks.  Looks good.\n\nErrr... in the commit message\n\n>> First, feed entries have whatchanged-like list of files which were\n>> modified in a commit, so 'commitdiff' view more naturally reflects\n>> feed entry (in more naturally alternate / extended version of a feed\n>> item). Second, this way the patches are shown directly and code review\n>> is done more easily via watching feeds.\n\n\"... (in more naturally ...\" should be \"... (is more naturally ...\".\n\nUnfortunately this kind of errors are hard to catch (and spellchecker\nwould not help any)\n\n-- \nJakub Narebski\nPoland\n"}]}