# [PATCH/RFC] gitweb: Make feed entries point to commitdiff view

3 messages from 2008-02-03 to 2008-02-06. Participants: Jakub Narebski, Junio C Hamano.
Thread: https://gitlist.dev/t/11851

## Jakub Narebski, 2008-02-03 11:38

Subject: [PATCH/RFC] gitweb: Make feed entries point to commitdiff view
Message-ID: <1202038726-4221-1-git-send-email-jnareb@gmail.com>
URL: https://gitlist.dev/e/1202038726-4221-1-git-send-email-jnareb%40gmail.com

```
From: Florian La Roche <laroche@redhat.com>

Change feeds entries (feeds items) from pointing (linking) to 'commit'
view to pointing to 'commitdiff' view.

First, feed entries have whatchanged-like list of files which were
modified in a commit, so 'commitdiff' view more naturally reflects
feed entry (in more naturally alternate / extended version of a feed
item). Second, this way the patches are shown directly and code review
is done more easily via watching feeds.

[jn: Rewritten commit message]

Signed-off-by: Florian La Roche <laroche@redhat.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This patch was originally send by Florian La Roche in
  "[PATCH] gitweb: Change feeds from commit to commitdiff output"

  Message-ID: <20080110130900.GA9395%40dudweiler.stuttgart.redhat.com>
  http://thread.gmane.org/gmane.comp.version-control.git/70068

As requested, Junio, I have marged this patch as an RFC, although
I think that with the improved commit message the reason for this
change is more obvious, and it is a go.

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index ae2d057..8ef2735 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -5565,7 +5565,7 @@ XML
 			or next;
 
 		# print element (entry, item)
-		my $co_url = href(-full=>1, action=>"commit", hash=>$commit);
+		my $co_url = href(-full=>1, action=>"commitdiff", hash=>$commit);
 		if ($format eq 'rss') {
 			print "<item>\n" .
 			      "<title>" . esc_html($co{'title'}) . "</title>\n" .
-- 
1.5.4

```

## Junio C Hamano, 2008-02-06 20:46

Subject: Re: [PATCH/RFC] gitweb: Make feed entries point to commitdiff view
Message-ID: <7vd4r9vmnd.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vd4r9vmnd.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <1202038726-4221-1-git-send-email-jnareb@gmail.com>

```
Jakub Narebski <jnareb@gmail.com> writes:

> I think that with the improved commit message the reason for this
> change is more obvious, and it is a go.

Thanks.  Looks good.

```

## Jakub Narebski, 2008-02-06 21:22

Subject: Re: [PATCH/RFC] gitweb: Make feed entries point to commitdiff view
Message-ID: <200802062222.38691.jnareb@gmail.com>
URL: https://gitlist.dev/e/200802062222.38691.jnareb%40gmail.com
In-Reply-To: <7vd4r9vmnd.fsf@gitster.siamese.dyndns.org>

```
Dnia środa 6. lutego 2008 21:46, Junio C Hamano napisał:
> Jakub Narebski <jnareb@gmail.com> writes:
> 
> > I think that with the improved commit message the reason for this
> > change is more obvious, and it is a go.
> 
> Thanks.  Looks good.

Errr... in the commit message

>> First, feed entries have whatchanged-like list of files which were
>> modified in a commit, so 'commitdiff' view more naturally reflects
>> feed entry (in more naturally alternate / extended version of a feed
>> item). Second, this way the patches are shown directly and code review
>> is done more easily via watching feeds.

"... (in more naturally ..." should be "... (is more naturally ...".

Unfortunately this kind of errors are hard to catch (and spellchecker
would not help any)

-- 
Jakub Narebski
Poland

```