[PATCH/RFC] gitweb: Make feed entries point to commitdiff view
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Feb 3, 2008, 11:38 UTC
- Message-ID
- <1202038726-4221-1-git-send-email-jnareb@gmail.com>
From: Florian La Roche <laroche@redhat.com>
Change feeds entries (feeds items) from pointing (linking) to 'commit' view to pointing to 'commitdiff' view.
First, feed entries have whatchanged-like list of files which were modified in a commit, so 'commitdiff' view more naturally reflects feed entry (in more naturally alternate / extended version of a feed item). Second, this way the patches are shown directly and code review is done more easily via watching feeds.
[jn: Rewritten commit message]
Signed-off-by: Florian La Roche <laroche@redhat.com> Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- This patch was originally send by Florian La Roche in "[PATCH] gitweb: Change feeds from commit to commitdiff output"
Message-ID: <20080110130900.GA9395%40dudweiler.stuttgart.redhat.com> http://thread.gmane.org/gmane.comp.version-control.git/70068
As requested, Junio, I have marged this patch as an RFC, although I think that with the improved commit message the reason for this change is more obvious, and it is a go.
gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index ae2d057..8ef2735 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -5565,7 +5565,7 @@ XML or next; # print element (entry, item) - my $co_url = href(-full=>1, action=>"commit", hash=>$commit); + my $co_url = href(-full=>1, action=>"commitdiff", hash=>$commit); if ($format eq 'rss') { print "<item>\n" . "<title>" . esc_html($co{'title'}) . "</title>\n" .
-- 1.5.4