threads / patch / 11210

patchRemove repo version check from setup_git_directory

Subject: [PATCH] Remove repo version check from setup_git_directory

## tl;dr

2 messages between Dec 9, 2007 and Dec 9, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Nguyễn Thái Ngọc Duy· Dec 9, 2007, 10:14 UTC · lore

setup_git_directory_gently has done the check already.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 Sorry, somehow I left this line behind. It should have been gone
 from my re-fix patch.

 setup.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Show changes to setup.c +0 −1

diff --git a/setup.c b/setup.c
index e96a316..b59dbe7 100644
--- a/setup.c
+++ b/setup.c
@@ -388,7 +388,6 @@ int check_repository_format(void)
 const char *setup_git_directory(void)
 {
 	const char *retval = setup_git_directory_gently(NULL);
-	check_repository_format();
 
 	/* If the work tree is not the default one, recompute prefix */
 	if (inside_work_tree < 0) {

-- 
1.5.3.7.2155.g4c25

Junio C Hamano· Dec 9, 2007, 10:24 UTC · re: Nguyễn Thái Ngọc Duy · lore

Re: [PATCH] Remove repo version check from setup_git_directory

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

Show 19 quoted lines

> setup_git_directory_gently has done the check already.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  Sorry, somehow I left this line behind. It should have been gone
>  from my re-fix patch.
>
>  setup.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/setup.c b/setup.c
> index e96a316..b59dbe7 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -388,7 +388,6 @@ int check_repository_format(void)
>  const char *setup_git_directory(void)
>  {
>  	const char *retval = setup_git_directory_gently(NULL);
> -	check_repository_format();

Ah, because the previous line already calls the same repository format check, this is now unneeded, indeed.

Thanks.