{"thread":{"id":"11210","subject":"[PATCH] Remove repo version check from setup_git_directory","startedAt":"2007-12-09T10:14:39Z","lastAt":"2007-12-09T10:24:38Z","messageCount":2,"participants":["Nguyễn Thái Ngọc Duy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"62474","messageId":"20071209101439.GA18312@laptop","threadId":"11210","inReplyTo":null,"subject":"[PATCH] Remove repo version check from setup_git_directory","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2007-12-09T10:14:39Z","receivedAt":"2007-12-09T10:14:39Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"setup_git_directory_gently has done the check already.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n Sorry, somehow I left this line behind. It should have been gone\n from my re-fix patch.\n\n setup.c |    1 -\n 1 files changed, 0 insertions(+), 1 deletions(-)\n\ndiff --git a/setup.c b/setup.c\nindex e96a316..b59dbe7 100644\n--- a/setup.c\n+++ b/setup.c\n@@ -388,7 +388,6 @@ int check_repository_format(void)\n const char *setup_git_directory(void)\n {\n \tconst char *retval = setup_git_directory_gently(NULL);\n-\tcheck_repository_format();\n \n \t/* If the work tree is not the default one, recompute prefix */\n \tif (inside_work_tree < 0) {\n-- \n1.5.3.7.2155.g4c25\n"},{"id":"62476","messageId":"7vd4tgrwrd.fsf@gitster.siamese.dyndns.org","threadId":"11210","inReplyTo":"20071209101439.GA18312@laptop","subject":"Re: [PATCH] Remove repo version check from setup_git_directory","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-09T10:24:38Z","receivedAt":"2007-12-09T10:24:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:\n\n> setup_git_directory_gently has done the check already.\n>\n> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n> ---\n>  Sorry, somehow I left this line behind. It should have been gone\n>  from my re-fix patch.\n>\n>  setup.c |    1 -\n>  1 files changed, 0 insertions(+), 1 deletions(-)\n>\n> diff --git a/setup.c b/setup.c\n> index e96a316..b59dbe7 100644\n> --- a/setup.c\n> +++ b/setup.c\n> @@ -388,7 +388,6 @@ int check_repository_format(void)\n>  const char *setup_git_directory(void)\n>  {\n>  \tconst char *retval = setup_git_directory_gently(NULL);\n> -\tcheck_repository_format();\n\nAh, because the previous line already calls the same repository format\ncheck, this is now unneeded, indeed.\n\nThanks.\n"}]}