# [PATCH] Remove repo version check from setup_git_directory 2 messages from 2007-12-09 to 2007-12-09. Participants: Nguyễn Thái Ngọc Duy, Junio C Hamano. Thread: https://gitlist.dev/t/11210 ## Nguyễn Thái Ngọc Duy, 2007-12-09 10:14 Subject: [PATCH] Remove repo version check from setup_git_directory Message-ID: <20071209101439.GA18312@laptop> URL: https://gitlist.dev/e/20071209101439.GA18312%40laptop ``` setup_git_directory_gently has done the check already. Signed-off-by: Nguyễn Thái Ngọc Duy --- Sorry, somehow I left this line behind. It should have been gone from my re-fix patch. setup.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/setup.c b/setup.c index e96a316..b59dbe7 100644 --- a/setup.c +++ b/setup.c @@ -388,7 +388,6 @@ int check_repository_format(void) const char *setup_git_directory(void) { const char *retval = setup_git_directory_gently(NULL); - check_repository_format(); /* If the work tree is not the default one, recompute prefix */ if (inside_work_tree < 0) { -- 1.5.3.7.2155.g4c25 ``` ## Junio C Hamano, 2007-12-09 10:24 Subject: Re: [PATCH] Remove repo version check from setup_git_directory Message-ID: <7vd4tgrwrd.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vd4tgrwrd.fsf%40gitster.siamese.dyndns.org In-Reply-To: <20071209101439.GA18312@laptop> ``` Nguyễn Thái Ngọc Duy writes: > setup_git_directory_gently has done the check already. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > Sorry, somehow I left this line behind. It should have been gone > from my re-fix patch. > > setup.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/setup.c b/setup.c > index e96a316..b59dbe7 100644 > --- a/setup.c > +++ b/setup.c > @@ -388,7 +388,6 @@ int check_repository_format(void) > const char *setup_git_directory(void) > { > const char *retval = setup_git_directory_gently(NULL); > - check_repository_format(); Ah, because the previous line already calls the same repository format check, this is now unneeded, indeed. Thanks. ```