git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Remove repo version check from setup_git_directory

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 9, 2007, 10:24 UTC
Message-ID
<7vd4tgrwrd.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20071209101439.GA18312@laptop>
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
Show 19 quoted lines
> setup_git_directory_gently has done the check already.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  Sorry, somehow I left this line behind. It should have been gone
>  from my re-fix patch.
>
>  setup.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/setup.c b/setup.c
> index e96a316..b59dbe7 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -388,7 +388,6 @@ int check_repository_format(void)
>  const char *setup_git_directory(void)
>  {
>  	const char *retval = setup_git_directory_gently(NULL);
> -	check_repository_format();

Ah, because the previous line already calls the same repository format check, this is now unneeded, indeed.

Thanks.
Previous: Nguyễn Thái Ngọc Duy
Message 2 of 2 in “Remove repo version check from setup_git_directory”
  1. Remove repo version check from setup_git_directoryNguyễn Thái Ngọc Duy, Dec 9, 2007
  2. Junio C HamanoDec 9, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.